Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switch fall-through in crn_decompress_block #11

Open
wants to merge 1 commit into
base: unity
Choose a base branch
from

Conversation

zellski
Copy link

@zellski zellski commented Nov 29, 2018

Do not immediately overwrite our DXT5-decompressed pixels with a cCRNFmtDXN_XY interpretation.

Do not immediately overwrite our DXT5-decompressed pixels with a cCRNFmtDXN_XY interpretation.
@illwieckz
Copy link

Hi, as one of the maintainer of the @DaemonEngine fork (see https://github.com/DaemonEngine/crunch), I'm interested in merging the fixes people submit if those fixes are not so much intrusive and/or if they fixes obvious bugs that has to be fixed in any way.

@zellski can you confirm

  • your change is not introducing behavioral change like making the produced format incompatible with the original one even if the original one would be faulty;
  • the fix has to be implemented by upstream one day in anyway because it's a bug that has to be fixed;
  • there is a low probability to see upstream implementing the fix another way;
  • there is no chance in your own humble opinion that upstream would fix the bug in another way that would introduce a behavioral change with your own fix.

If you can answer Yes to all those questions I may merge your fix in @DaemonEngine fork which is actively maintained to bring fixes while keeping in sync with upstream, hoping for a merge one day, see DaemonEngine#2. Thank you in advance.

@zellski
Copy link
Author

zellski commented Jun 2, 2019

Uh, no, I can't confirm all that, but it's a bugfix and you're free to use it.

@illwieckz
Copy link

@zellski by bugfix do you mean the current code (without your patch) is always wrong?

@ghost
Copy link

ghost commented Jan 18, 2022

I do not understand the code behind, since I don't know the algo and format, but here, a compiler would warn about fallthrough, and it's the only case in which there's a fallthrough.
To me, this is clearly a safe bugfix. That is, I'd rather test in debug situations if any problem arise than let this sleeping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants