Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: enable /MP and /W4 on MSVC #50

Closed
wants to merge 2 commits into from
Closed

cmake: enable /MP and /W4 on MSVC #50

wants to merge 2 commits into from

Conversation

illwieckz
Copy link
Member

@illwieckz illwieckz commented Jun 25, 2024 •
edited
Loading

Enable /MP and /W4 on MSVC.

@illwieckz illwieckz force-pushed the illwieckz/msvc-flags branch 2 times, most recently from 6f68853 to 84e7255 Compare June 25, 2024 09:15
@illwieckz
Copy link
Member Author

illwieckz commented Jun 25, 2024 •
edited
Loading

It's a bad idea to enable /Wall, it expands the MSVC build time from 2 min 30 to 8 min 30… Probably just because of the time it spends to prints all the warning lines… It's longer than a full Dæmon engine build!

And this is for only one job, there are two of them…

@illwieckz illwieckz changed the title cmake: enable /MP and /Wall on MSVC cmake: enable /MP on MSVC Jun 25, 2024
@illwieckz illwieckz force-pushed the illwieckz/msvc-flags branch from 84e7255 to 16f9124 Compare June 25, 2024 10:12
@illwieckz illwieckz changed the title cmake: enable /MP on MSVC cmake: enable /MP and /W4 on MSVC Jun 25, 2024
@illwieckz
Copy link
Member Author

I implemented /W4 instead of /Wall.

@illwieckz
Copy link
Member Author

Closed in favor of:

@illwieckz illwieckz closed this Jun 26, 2024
@illwieckz illwieckz deleted the illwieckz/msvc-flags branch June 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illwieckz