-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes some bugs in examples and factorize some code, test them in CI #61
Conversation
Fix execution on machines having more than 15 threads/cores. Also substract by 1 (the main thread) the amount of all threads to get the amount of helper thread in all cases.
9ca3203
to
ecd2312
Compare
The example1 CRN to DDS test doesn't work on macOS CI, I don't know why because I don't reproduce it on my end on macOS. |
a8da546
to
bf1afd3
Compare
If I decode that file on my end and run crunch (even macOS crunch) on it, it says it's a valid crn file and decompresses it! But it doesn't work in CI… |
bf1afd3
to
39ff192
Compare
ff76d5d
to
2dc2801
Compare
Now fixed, a null-terminator was missing. |
41eecb0
to
4e24afa
Compare
I don't know why the |
I reproduce a crash. It crashes when calling |
It should be doable for
|
4e24afa
to
e090f43
Compare
So |
feb8fc9
to
89bc6f7
Compare
This also extends the testing by running cross-compiled executables when possible (using |
6652709
to
ac88f0a
Compare
ac88f0a
to
ec36144
Compare
To avoid some warnings related to I also added two commits fixing two kind of warnings in examples. |
fa51891
to
3dadb5c
Compare
a0eca7d
to
d0d6b4e
Compare
LGTM |
d0d6b4e
to
632d422
Compare
Fixes some bugs in examples and factorize some code.
The examples are now tested in CI.