Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for code readability and maintainability #52

Merged
merged 9 commits into from
Dec 27, 2023
Merged

Suggestions for code readability and maintainability #52

merged 9 commits into from
Dec 27, 2023

Conversation

wuletawwonte
Copy link
Contributor

@wuletawwonte wuletawwonte commented Dec 22, 2023 •
edited
Loading

🏁 Checks

  • Unit test passes

@wuletawwonte wuletawwonte changed the title Few suggestions for code readability and maintainability Suggestions for code readability and maintainability Dec 22, 2023
@wuletawwonte wuletawwonte marked this pull request as ready for review December 22, 2023 18:05
Dagic-zewdu
Dagic-zewdu reviewed Dec 27, 2023
View reviewed changes
Copy link
Owner

@Dagic-zewdu Dagic-zewdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the conflict

To ensure a seamless integration, please take a moment to address any conflicts that may be present. Resolving these conflicts will significantly enhance the code's readability and maintainability for future iterations. I'm eager to review the code once the conflicts have been effectively addressed. ☮️

@wuletawwonte
Copy link
Contributor Author

@Dagic-zewdu
The conflict occurred due to the previous code format merge. I will fix it now.

@wuletawwonte
Copy link
Contributor Author

@Dagic-zewdu
I have resolved the merge conflict. I think it is ready for a review now.

Dagic-zewdu
Dagic-zewdu approved these changes Dec 27, 2023
View reviewed changes
Copy link
Owner

@Dagic-zewdu Dagic-zewdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wuletawwonte ,

Wow, you did it 🎉

Brilliant

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

@Dagic-zewdu Dagic-zewdu merged commit 2ee64ad into Dagic-zewdu:dev Dec 27, 2023
3 checks passed
@wuletawwonte wuletawwonte deleted the refactor-code branch December 27, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dagic-zewdu Dagic-zewdu Dagic-zewdu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuletawwonte @Dagic-zewdu