Skip to content
This repository has been archived by the owner on Apr 25, 2020. It is now read-only.

Correction on formatted string for Emacs ghc lint #875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correction on formatted string for Emacs ghc lint #875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions elisp/ghc-check.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,13 @@ nil do not display errors/warnings.
(if ghc-check-command
(let ((opts (ghc-haskell-list-of-string ghc-hlint-options)))
(if opts
(format "lint %s %s\n" opts file)
(format "ascii-escape lint %s %s\n\n" opts file)
(format "lint %s\n" file)))
(format "check %s\n" file))))

(defun ghc-haskell-list-of-string (los)
(when los
(concat "["
(mapconcat (lambda (x) (concat "\"" x "\"")) los ", ")
"]")))
(mapconcat (lambda (x) (concat "-h\x02" x "\x03")) los " ")))

(defun ghc-check-callback (status)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I honestly didn't know we were already doing some form of escaping here. I think we might have just broken B/C at some point. I'll have to look into that.

(cond
Expand Down