fix(fuzzer): Fix toSql methods for NestedLoopJoinNode in Reference Qu…

…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte · Dec 14, 2024 · 12830d0 · 12830d0
1 parent 03d71c5
commit 12830d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/velox/exec/fuzzer/DuckQueryRunner.cpp b/velox/exec/fuzzer/DuckQueryRunner.cpp
@@ -450,6 +450,8 @@ std::optional<std::string> DuckQueryRunner::toSql(
     const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
   std::stringstream sql;
 
+  sql << "SELECT " << folly::join(", ", outputNames);
+
   // Nested loop join without filter.
   VELOX_CHECK(
       joinNode->joinCondition() == nullptr,

diff --git a/velox/exec/fuzzer/PrestoQueryRunner.cpp b/velox/exec/fuzzer/PrestoQueryRunner.cpp
@@ -670,6 +670,8 @@ std::optional<std::string> PrestoQueryRunner::toSql(
     const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
   std::stringstream sql;
 
+  sql << "SELECT " << folly::join(", ", outputNames);
+
   // Nested loop join without filter.
   VELOX_CHECK(
       joinNode->joinCondition() == nullptr,