fix(fuzzer): Fix toSql methods for NestedLoopJoinNode in Reference Qu…

…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte · Dec 4, 2024 · 5ed68b4 · 5ed68b4
1 parent b93b474
commit 5ed68b4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/velox/exec/fuzzer/DuckQueryRunner.cpp b/velox/exec/fuzzer/DuckQueryRunner.cpp
@@ -448,8 +448,11 @@ std::optional<std::string> DuckQueryRunner::toSql(
 
 std::optional<std::string> DuckQueryRunner::toSql(
     const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
+  const auto& outputNames = joinNode->outputType()->names();
   std::stringstream sql;
 
+  sql << "SELECT " << folly::join(", ", outputNames);
+
   // Nested loop join without filter.
   VELOX_CHECK(
       joinNode->joinCondition() == nullptr,

diff --git a/velox/exec/fuzzer/PrestoQueryRunner.cpp b/velox/exec/fuzzer/PrestoQueryRunner.cpp
@@ -662,8 +662,11 @@ std::optional<std::string> PrestoQueryRunner::toSql(
 
 std::optional<std::string> PrestoQueryRunner::toSql(
     const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
+  const auto& outputNames = joinNode->outputType()->names();
   std::stringstream sql;
 
+  sql << "SELECT " << folly::join(", ", outputNames);
+
   // Nested loop join without filter.
   VELOX_CHECK(
       joinNode->joinCondition() == nullptr,