Skip to content

Commit

Permalink
test: Disable O_DIRECT in cache fuzzer (facebookincubator#12154)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookincubator#12154

O_DIRECT requires I/O size needs to be the same as a disk file block size
which is not handled in SSD cache. Misalignment can lead to EINVAL in some
filesystem and kernel version.

Reviewed By: xiaoxmeng, kagamiori, yuandagits

Differential Revision: D68562695

fbshipit-source-id: 5a3dbdfed288dfb8cfa606f9d40fe0e2c0568f8a
  • Loading branch information
zacw7 authored and facebook-github-bot committed Jan 28, 2025
1 parent 2d24256 commit 9999ae0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
4 changes: 2 additions & 2 deletions velox/common/file/tests/FaultyFileSystem.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ class FaultyFileSystem : public FileSystem {
// Extracts the delegated real file path by removing the faulty file system
// scheme prefix.
inline std::string_view extractPath(std::string_view path) const override {
VELOX_CHECK_EQ(path.find(scheme()), 0, "");
const auto filePath = path.substr(scheme().length());
const auto filePath =
(path.find(scheme()) == 0) ? path.substr(scheme().length()) : path;
return getFileSystem(filePath, config_)->extractPath(filePath);
}

Expand Down
7 changes: 6 additions & 1 deletion velox/exec/fuzzer/CacheFuzzer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include "velox/common/memory/MmapAllocator.h"
#include "velox/dwio/common/CachedBufferedInput.h"
#include "velox/exec/tests/utils/TempDirectoryPath.h"
#include "velox/vector/fuzzer/Utils.h"

DEFINE_int32(steps, 10, "Number of plans to generate and test.");

Expand Down Expand Up @@ -498,6 +497,12 @@ void CacheFuzzer::go() {
FLAGS_steps > 0 || FLAGS_duration_sec > 0,
"Either --steps or --duration_sec needs to be greater than zero.");

// O_DIRECT requires I/O size to be the same as a disk file block size which
// is not handled in SSD cache. Misalignment can lead to EINVAL in some
// filesystem and kernel version.
//
// TODO: add this support if needed later.
FLAGS_ssd_odirect = false;
auto startTime = std::chrono::system_clock::now();
size_t iteration = 0;

Expand Down

0 comments on commit 9999ae0

Please sign in to comment.