Skip to content

Commit

Permalink
Use succinctMillis to print task running time (facebookincubator#10683)
Browse files Browse the repository at this point in the history
Summary:
`succinctMillis` will help unify time unit.

Pull Request resolved: facebookincubator#10683

Reviewed By: kagamiori

Differential Revision: D60903986

Pulled By: xiaoxmeng

fbshipit-source-id: 5856064b3f03c7665650eb448b2bc4ef65542f21
  • Loading branch information
Yohahaha authored and facebook-github-bot committed Aug 8, 2024
1 parent e7a6ffc commit c6c67f1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions velox/exec/Task.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1140,8 +1140,8 @@ void Task::removeDriver(std::shared_ptr<Task> self, Driver* driver) {
if (self->numFinishedDrivers_ == self->numTotalDrivers_) {
LOG(INFO) << "All drivers (" << self->numFinishedDrivers_
<< ") finished for task " << self->taskId()
<< " after running for " << self->timeSinceStartMsLocked()
<< " ms.";
<< " after running for "
<< succinctMillis(self->timeSinceStartMsLocked());
}
}
stateChangeNotifier.notify();
Expand Down Expand Up @@ -1880,7 +1880,7 @@ ContinueFuture Task::terminate(TaskState terminalState) {

LOG(INFO) << "Terminating task " << taskId() << " with state "
<< taskStateString(state_) << " after running for "
<< timeSinceStartMsLocked() << " ms.";
<< succinctMillis(timeSinceStartMsLocked());

taskCompletionNotifier.activate(
std::move(taskCompletionPromises_), [&]() { onTaskCompletion(); });
Expand Down

0 comments on commit c6c67f1

Please sign in to comment.