fix(fuzzer) Fix toSql methods for NestedLoopJoinNode in Reference Que…

…ry Runners Summary: The select clause is completely missing in the produced query string. Differential Revision: D66132514
DanielHunte · Nov 18, 2024 · de208a3 · de208a3
1 parent d203a23
commit de208a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 22 deletions.
diff --git a/velox/exec/fuzzer/DuckQueryRunner.cpp b/velox/exec/fuzzer/DuckQueryRunner.cpp
@@ -428,20 +428,11 @@ std::optional<std::string> DuckQueryRunner::toSql(
 
 std::optional<std::string> DuckQueryRunner::toSql(
     const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
-  const auto& joinKeysToSql = [](auto keys) {
-    std::stringstream out;
-    for (auto i = 0; i < keys.size(); ++i) {
-      if (i > 0) {
-        out << ", ";
-      }
-      out << keys[i]->name();
-    }
-    return out.str();
-  };
-
   const auto& outputNames = joinNode->outputType()->names();
   std::stringstream sql;
 
+  sql << "SELECT " << folly::join(", ", outputNames);
+
   // Nested loop join without filter.
   VELOX_CHECK(
       joinNode->joinCondition() == nullptr,

diff --git a/velox/exec/fuzzer/PrestoQueryRunner.cpp b/velox/exec/fuzzer/PrestoQueryRunner.cpp
@@ -643,20 +643,11 @@ std::optional<std::string> PrestoQueryRunner::toSql(
 
 std::optional<std::string> PrestoQueryRunner::toSql(
     const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
-  const auto& joinKeysToSql = [](auto keys) {
-    std::stringstream out;
-    for (auto i = 0; i < keys.size(); ++i) {
-      if (i > 0) {
-        out << ", ";
-      }
-      out << keys[i]->name();
-    }
-    return out.str();
-  };
-
   const auto& outputNames = joinNode->outputType()->names();
   std::stringstream sql;
 
+  sql << "SELECT " << folly::join(", ", outputNames);
+
   // Nested loop join without filter.
   VELOX_CHECK(
       joinNode->joinCondition() == nullptr,