Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add IPAddress Presto type (facebookincubator#10596)
Summary: Split of facebookincubator#10538 In response to mbasmanova : facebookincubator#10538 (review) Took a look and added the to and from varbinary casting Contains CAST functions for IPAddress <-> Varchar and IPAddress <-> Varbinary utilizing the folly library. In response to: https://velox-lib.io/blog/optimize-try-more I believe the folly library utilizes makeUnexpected already. https://github.com/facebook/folly/blob/main/folly/IPAddress.cpp I added one error for Varbinary conversion utilizing `context.setStatus` If I'm not understanding something correctly please let me know. As for adding a limited fuzzer aditi-pandit facebookincubator#10538 (comment) Is this to test the casting `IPAddress <-> Varchar and IPAddress <-> Varbinary` or something else. We already test the casting using the duckdb type, we also have the prestissimo test in the E2E test. Fuzzer support will be added in after the types and functions have been added. Pull Request resolved: facebookincubator#10596 Reviewed By: bikramSingh91 Differential Revision: D61163377 Pulled By: xiaoxmeng fbshipit-source-id: 2c0fa2e8e6d250a2167a1ff82b2878548798a226
- Loading branch information