New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esbuild plugin can be passed compile options #17

Merged

STRd6 merged 1 commit into main from esbuild-options

Apr 24, 2024

Collaborator

edemaine commented Apr 24, 2024

(as discussed on Discord)

I think filename was also previously passed into the wrong function (parse instead of compile)
parse no longer needs to be called; compile calls parse if the first argument is a string

BREAKING CHANGE: esbuild plugin now needs to be called

I've tested this with module: true where I need it in my Civet branch.


          esbuild plugin can be passed compile options

a66dc88

BREAKING CHANGE: esbuild plugin now needs to be called

STRd6 approved these changes

View reviewed changes

STRd6 merged commit 2cbc0d3 into main

4 checks passed

edemaine deleted the esbuild-options branch

April 25, 2024 12:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet