Add option to persist enum names #1762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new `PersistEnumsByName` setting is true, an enum is persisted by its name (`Enum.ToString()`) instead of by its underlying numeric value.
|
Nice improvement! Is there an ETA for this to get into a release? |
Hello from 2023 eve. There are a bunch of same Dapper enum issues opened for 8 years, and nobody gives a damn about it. I'm thinking of forking the library, merging commits above into it, and publish to NuGet so everybody could finally use a mature version of this ORM 😂 |
|
Will this ever be in a release? |
SeppPenner
reviewed
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new
PersistEnumsByNamesetting is true, an enum is persisted by its name (Enum.ToString()) instead of by its numeric value.This is sort of an alternative solution to issue #259, but it doesn't directly address that issue by changing how custom type handlers are used. Instead, it adds a new setting,
PersistEnumsByName, which I believe addresses what most users actually want - to be able to persist an enums by their name. When this setting is false (its default value), the current behavior is completely unchanged. Admittedly, there is no granularity with how enums are handled; you couldn't have some enums persisted by name and others by their underlying value. Supporting that scenario would add significant complexity, and I don't think there is enough demand to justify it.Fixes #813.