add support for fetching values via GetFieldValue<T> #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DbDataReader, but in reality the reader is *always* DbDataReader; acknowledge this, and stop pretending to use IDataReader internally (no breaks to public API)
NickCraver
reviewed
Jun 9, 2023
|
Emphasis: this PR proves everything I am saying in #1909 - maintaining IL emit code is hard |
|
all CI is green @NickCraver |
NickCraver
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this requires
DbDataReader, but in reality the reader is alwaysDbDataReader; acknowledge this, and stop pretending to useIDataReaderinternallyThe primary use for this is things like
SqlDecimalwhich cannot be accessed other than viaDbDataReader.GetFieldValue<T>or viaSqlDataReader.GetSqlDecimalfix #1907
the most relevant parts are:
Query<SqlDecimal>, the addition ofReadViaGetFieldValueFactorywhich is a per-T cached factory method that works a lot like the old logic (now enshrined inReadViaGetValue), but usingIsDbNullandGetFieldValue<T>LoadReaderValueViaGetFieldValue, which reads a value in IL viaIsDbNullandGetFieldValue<T>; the use ofIsDbNullmeans that we won't have anything to pop on the stack (unlike the old with did a read, dup, test, branch - leaving the original copy on the stack if we branched), which is tracked viapopWhenNull