Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Atrribute Column #681

Closed
wants to merge 2 commits into from
Closed

Conversation

scampos-s3d
Copy link

Added the attribute column. It allows to define the column name.

@NickCraver
Copy link
Member

The reasons we've never included such a thing is: it doesn't cover most cases. For example if you called any get methods, a column wouldn't map back properly. Including on Select * style approaches.

There's also a question of "does such a feature even need a new attribute?" or would [DataMemeber] suffice? But for anyone with currently decorated classes (e.g. for JSON serialization), this would be a breaking change and quite unexpected behavior.

In short: this would have to manifest in far more ways, and likely be in Dapper itself, not contrib. I'm not sure it meets the bar on demand, since it's nothing like the built-in behavior. It's worth taking a look at holistically in Dapper v2 though, from a view point of which bits of Contrib should migrate to Dapper core.

@NickCraver NickCraver added the v3.0 Changes awaiting the next breaking release label Jan 28, 2017
@NickCraver NickCraver added this to the v2.0 milestone Jan 30, 2017
@NickCraver
Copy link
Member

Closing this out to consolidate - please check out and add your thoughts to the feature design in #722!

@NickCraver NickCraver closed this Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.0 Changes awaiting the next breaking release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants