Hometask 2 #2
Open
Hometask 2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-ivanov
requested changes
Oct 30, 2019
| } | ||
|
|
||
| for (Room room : smartHome.getRooms()) { | ||
| for (Light light : room.getLights()) { |
There was a problem hiding this comment.
Этот цикл должен быть заменен на внутренний итератор по 2му заданию. Вся итерацию должны делать объекты дома, а не кто-то со стороны. Исправьте.
| package ru.sbt.mipt.oop; | ||
|
|
||
| public interface Actionable { | ||
| String getId(); |
There was a problem hiding this comment.
Нарушение SRP - единственная ответственность - execute(Action action). Исправьте.
| if (!isDoorEvent(event)) { | ||
| return; | ||
| } | ||
| for (Room room : smartHome.getRooms()) { |
There was a problem hiding this comment.
Перенести цикл внутрь объектов дома.
a-ivanov
requested changes
Dec 12, 2019
| @@ -21,4 +22,9 @@ public void addRoom(Room room) { | |||
| public Collection<Room> getRooms() { | |||
There was a problem hiding this comment.
Этого метода не должно быть - вся итерация внутри void execute(Action action).
| @@ -24,4 +24,9 @@ public Room(Collection<Light> lights, Collection<Door> doors, String name) { | |||
| public String getName() { | |||
| return name; | |||
| } | |||
|
|
|||
| public void execute(Action action) { | |||
| action.executeObj(this); | |||
There was a problem hiding this comment.
Где итерация по свету и дверям?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.