Skip to content

Commit

Permalink
Merge pull request #21 from Dash-Kit/release/3.5.1
Browse files Browse the repository at this point in the history
Removed http package due to conflicts with old packages
  • Loading branch information
w3ggy authored Oct 4, 2023
2 parents 54479b5 + e9510d0 commit f4bbe67
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 123 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## [3.5.1]
- Removed `http` package due to conflicts with old packages

## [3.5.0]
- Bump dependencies

Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ Removed the following dependencies:
- shake
- chopper: ^3.0.2
- chewie: ^0.9.10
- video_player: ^0.10.8+1
- video_player: ^0.10.8+1
- http: ^1.1.0
18 changes: 6 additions & 12 deletions lib/alice.dart
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import 'dart:io';
import 'package:alice_lightweight/core/alice_http_adapter.dart';
import 'package:alice_lightweight/model/alice_http_call.dart';

import 'package:http/http.dart' as http;
import 'package:alice_lightweight/core/alice_core.dart';
import 'package:alice_lightweight/core/alice_dio_interceptor.dart';
import 'package:alice_lightweight/core/alice_http_client_adapter.dart';
Expand All @@ -16,10 +14,13 @@ class Alice {
GlobalKey<NavigatorState> _navigatorKey;
AliceCore _aliceCore;
AliceHttpClientAdapter _httpClientAdapter;
AliceHttpAdapter _httpAdapter;

Alice._(this.darkTheme, this._navigatorKey, this._aliceCore,
this._httpClientAdapter, this._httpAdapter);
Alice._(
this.darkTheme,
this._navigatorKey,
this._aliceCore,
this._httpClientAdapter,
);

/// Creates alice instance.
factory Alice({
Expand All @@ -29,14 +30,12 @@ class Alice {
}) {
final aliceCore = AliceCore(navigatorKey, darkTheme);
final httpClientAdapter = AliceHttpClientAdapter(aliceCore);
final httpAdapter = AliceHttpAdapter(aliceCore);

return Alice._(
darkTheme,
navigatorKey,
aliceCore,
httpClientAdapter,
httpAdapter,
);
}

Expand Down Expand Up @@ -67,11 +66,6 @@ class Alice {
_httpClientAdapter.onResponse(response, request, body: body);
}

/// Handle both request and response from http package
void onHttpResponse(http.Response response, {dynamic body}) {
_httpAdapter.onResponse(response, body: body);
}

/// Opens Http calls inspector. This will navigate user to the new fullscreen
/// page where all listened http calls can be viewed.
void showInspector() {
Expand Down
88 changes: 0 additions & 88 deletions lib/core/alice_http_adapter.dart

This file was deleted.

12 changes: 0 additions & 12 deletions lib/core/alice_http_extensions.dart

This file was deleted.

8 changes: 0 additions & 8 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,6 @@ packages:
description: flutter
source: sdk
version: "0.0.0"
http:
dependency: "direct main"
description:
name: http
sha256: "759d1a329847dd0f39226c688d3e06a6b8679668e350e2891a6474f8b4bb8525"
url: "https://pub.dev"
source: hosted
version: "1.1.0"
http_parser:
dependency: transitive
description:
Expand Down
3 changes: 1 addition & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: alice_lightweight
description: Lightweight Alice version. Removed additional dependencies except dio.
version: 3.5.0
version: 3.5.1
homepage: https://github.com/jhomlala/alice

environment:
Expand All @@ -9,7 +9,6 @@ environment:
dependencies:
flutter:
sdk: flutter
http: ^1.1.0
dio: ^5.3.3
rxdart: ^0.27.7
share_plus: ^7.1.0
Expand Down

0 comments on commit f4bbe67

Please sign in to comment.