FE-349 add data clean up to hca ingest manifest.py #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions upper case. Also removed the load_hca partition creation - that pipeline is no longer used.
snovod
approved these changes
Nov 7, 2024
checkout cache
setup-gcloud setup-python
setup-python
…ocker image. Allow latest
…ingest-manifest_dot_py' into FE-349-Add-data-clean-up-to-HCA-ingest-manifest_dot_py
|
Closing this one - I needed to fix the actions and the env was hosed in this branch. |
bahill
deleted the
FE-349-Add-data-clean-up-to-HCA-ingest-manifest_dot_py
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Relevant ticket FE-349
This PR
Errors in the wrangler-provided values can cause errors in the ingest pipeline.
To save time in debugging and clean up, I've should updated the script to:
I also removed an unused partition set, and updated the readme with information about binary authorization (no secrets, just that it exists, in case someone runs into issues pulling a new image), and because of BA added a clear declaration of the location of the Scala image.
Tested on the dev instance
Snapshot on Dev TDR
Checklist