Skip to content

Commit

Permalink
switch to always to avoid confusion
Browse files Browse the repository at this point in the history
wip
  • Loading branch information
snf2ye committed Jan 11, 2024
1 parent a52e5d8 commit e140272
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dev-image-update.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
needs: [ update_image, helm_tag_bump, cherry_pick_image_to_production_gcr ]
uses: ./.github/workflows/notify-slack.yaml
secrets: inherit
if: ${{ !cancelled() }}
if: ${{ always() }}
with:
workflow_name: Dev Image Update
notify_on_success: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/helmtagbump.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
needs: [ integration_helm_tag_update, ui_helm_default_chart_tag ]
uses: ./.github/workflows/notify-slack.yaml
secrets: inherit
if: ${{ !cancelled() }}
if: ${{ always() }}
with:
workflow_name: Helm Tag Bump
notify_on_failure: ${{ inputs.notify-slack }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
needs: [e2e_test]
uses: ./.github/workflows/notify-slack.yaml
secrets: inherit
if: ${{ !cancelled() }}
if: ${{ always() }}
with:
workflow_name: Nightly E2E Tests
notify_on_success: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
needs: [ unit_test ]
uses: ./.github/workflows/notify-slack.yaml
secrets: inherit
if: ${{ !cancelled() }}
if: ${{ always() }}
with:
workflow_name: Nightly Unit Tests
notify_on_success: true
Expand Down

0 comments on commit e140272

Please sign in to comment.