Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-1122] Apply zizmor suggestions #1733

Merged
merged 4 commits into from
Jan 15, 2025
Merged

[DT-1122] Apply zizmor suggestions #1733

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aea9c4d
fix: implement zizmor suggestions
fboulnois Jan 8, 2025
e2ee315
fix: bumper needs to use git token
fboulnois Jan 9, 2025
592ce3f
fix: merge action needs to use git token
fboulnois Jan 10, 2025
21dc73b
fix: double quote for bash expansion
fboulnois Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/dev-image-update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,23 @@ jobs:
DISABLE_ESLINT_PLUGIN: true
run: |
rm -rf jade-dev-account.pem
docker build -t gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:${GCR_TAG} --build-arg CACHEBUST=$(date +%s) .
docker build -t gcr.io/${gcr_google_project}/jade-data-repo-ui:${GCR_TAG} --build-arg CACHEBUST=$(date +%s) .
fboulnois marked this conversation as resolved.
Show resolved Hide resolved
# Push the Docker image to Google Container Registry
- name: Publish and tag new docker container to GCR
run: |
gcloud auth activate-service-account --key-file jade-dev-account.json
gcloud auth configure-docker --quiet
docker push gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:${GCR_TAG}
docker push gcr.io/${gcr_google_project}/jade-data-repo-ui:${GCR_TAG}
gcloud container images \
add-tag \
gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:"${GCR_TAG}" \
gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:"${{ steps.uiprevioustag.outputs.tag }}" --quiet
gcr.io/${gcr_google_project}/jade-data-repo-ui:"${GCR_TAG}" \
gcr.io/${gcr_google_project}/jade-data-repo-ui:"${PREV_TAG}" --quiet
gcloud container images \
add-tag \
gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:"${GCR_TAG}" \
gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:"${GCR_TAG}-develop" --quiet
gcr.io/${gcr_google_project}/jade-data-repo-ui:"${GCR_TAG}" \
gcr.io/${gcr_google_project}/jade-data-repo-ui:"${GCR_TAG}-develop" --quiet
env:
PREV_TAG: ${{ steps.uiprevioustag.outputs.tag }}
fboulnois marked this conversation as resolved.
Show resolved Hide resolved
helm_tag_bump:
needs: update_image
uses: ./.github/workflows/helmtagbump.yaml
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/helmtagbump.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
with:
fetch-depth: 0
ref: develop
persist-credentials: false
- name: 'Get Previous tag'
id: uiprevioustag
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
steps:
- name: Check out the repository
uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
steps:
- name: Check out the repository
uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
steps:
- name: Check out the repository
uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/trivy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
persist-credentials: false
- uses: broadinstitute/dsp-appsec-trivy-action@v1
Loading