-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-6563] Attribute ressource URL to LCP #3154
✨ [RUM-6563] Attribute ressource URL to LCP #3154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
==========================================
- Coverage 93.71% 93.68% -0.03%
==========================================
Files 291 291
Lines 7670 7670
Branches 1747 1747
==========================================
- Hits 7188 7186 -2
- Misses 482 484 +2 ☔ View full report in Codecov by Sentry. |
d314d33
to
3c0c395
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before making these changes, you'll want to add the new field to rum-events-format
; it goes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
LCP is often caused by a big image being rendered. If we can find which image was loaded at that time, we could have a field like: @view.largest_contentful_paint_resource_url:https://...
Changes
Adding new field to indicate the ressource url of the largest contentful paint
Testing
I have gone over the contributing documentation.