Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove RumContext type #3319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔥 Remove RumContext type #3319

wants to merge 1 commit into from

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Feb 4, 2025

Motivation

Remove RumContext type in favor of CommonProperties type which is auto generated by the rum event format.

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner February 4, 2025 16:33
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (08fb157) to head (3cb0a2a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3319   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         290      290           
  Lines        7703     7703           
  Branches     1754     1754           
=======================================
  Hits         7203     7203           
  Misses        500      500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants