Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When assembling an event for a given timestamp, the view context is found, but the URL context is missing. (cf telemetry PR)
This happens because both
viewHistory
andurlContexts
rely oncreateValueHistory
, which clears old entries viasetInterval
. So, the clean-up task of the URL context occurs before the view context.urlContexts
cleanup task runs first.viewHistory
cleanup task runs.urlContexts
cleanup task runsviewHistory
cleanup task runsChanges
createValueHistory
so that all valueHistory instances clear old entries in the same synchronous taskTesting
I have gone over the contributing documentation.