Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUM-8123] Introduce a hook to assemble events #3330

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Feb 6, 2025

Motivation

Following #3313, reintroduce the hook assemble but keep the contextUrl check in the assembly for now

Changes

  • Introduce a Hooks system
  • Use the Assemble hook in viewCollection to manage the assembly of view properties
  • Use the Assemble hook in urlContext to manage the assembly of url properties

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner February 6, 2025 15:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (b7fcfcb) to head (cd21fa0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
+ Coverage   92.96%   93.02%   +0.05%     
==========================================
  Files         297      298       +1     
  Lines        7851     7868      +17     
  Branches     1791     1793       +2     
==========================================
+ Hits         7299     7319      +20     
+ Misses        552      549       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amortemousque amortemousque merged commit 46af93d into main Feb 10, 2025
19 checks passed
@amortemousque amortemousque deleted the aymeric/introduce-hook-system-2 branch February 10, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants