NDM: Upgrade pro-bing to fix a windows only bug

[FlorianVeaux]

Internal context: https://datadoghq.atlassian.net/wiki/spaces/II/pages/3860988548/BUG+Windows+Ping+Buffer+Issue

A windows-only issue affects the pro-bing library, described in this issue: prometheus-community/pro-bing#34

With this PR, we replace the pro-bing version to the one from a personal fork from @ken-schneider. Once the PR is merged upstream, we'll move back to the main branch.

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: fb63d419-a0f0-41b0-a160-fe088e4d5e69 Metrics dashboard Target profiles

Baseline: 8779d4a
Comparison: 3e3c1e4

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	file_tree	memory utilization	+0.35	[+0.30, +0.40]	Logs
➖	idle	memory utilization	+0.32	[+0.28, +0.36]	Logs
➖	otel_to_otel_logs	ingress throughput	+0.16	[-0.65, +0.97]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	-0.75	[-5.52, +4.02]	Logs
➖	basic_py_check	% cpu utilization	-1.18	[-3.78, +1.41]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.71	[-2.59, -0.83]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-3.61	[-16.16, +8.94]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[hestonhoffman]

Tiny edit

[ken-schneider]

@FlorianVeaux would you mind pulling in the latest changes from the fork? I tested again and my calculation was slightly off.

It's unlikely we'd hit the issue ourselves, but it appears that the buffer needs to be large enough to hold:
p.Size + (ipv4.HeaderLen+8)*2. Even though net doesn't give us the original IP header, the underlying buffer needs to be large enough to hold it

[ken-schneider]

Updated the hash to point to the latest changes, should be good to go now

[ken-schneider]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!