Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file experiments to the use of logrotate FS #30750

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

blt
Copy link
Contributor

@blt blt commented Nov 5, 2024

This commit updates the file_to_blackhole experiments to rely on the lading logrotate FS generator, allowing us to assert on whether the log Agent loses bytes in the course of its operation. I've added a new check asserting that no bytes are lost, although I do not expect this to pass on higher latency intake experiments yet.

REF #30744
REF DataDog/lading#1090

@blt blt requested a review from a team as a code owner November 5, 2024 00:57
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Nov 5, 2024
@blt blt added changelog/no-changelog team/single-machine-performance Single Machine Performance qa/no-code-change No code change in Agent code requiring validation labels Nov 5, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 5, 2024

[Fast Unit Tests Report]

On pipeline 48406089 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Nov 5, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d22e2498-fb6e-4bd8-9789-76749bb1ae76

Baseline: 6fd7141
Comparison: a7e507e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +0.69 [-2.81, +4.19] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.41 [+0.35, +0.47] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.13 [-0.60, +0.86] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.26, +0.27] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.09] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.40, +0.37] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.22, +0.17] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.28, +0.20] 1 Logs
quality_gate_idle memory utilization -0.10 [-0.15, -0.06] 1 Logs bounds checks dashboard
idle_all_features memory utilization -0.11 [-0.21, -0.00] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.11 [-0.60, +0.38] 1 Logs
idle memory utilization -0.20 [-0.25, -0.15] 1 Logs bounds checks dashboard
file_tree memory utilization -0.38 [-0.51, -0.25] 1 Logs
quality_gate_idle_all_features memory utilization -0.40 [-0.50, -0.29] 1 Logs bounds checks dashboard
basic_py_check % cpu utilization -3.05 [-6.90, +0.81] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10 bounds checks dashboard
idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@blt blt force-pushed the blt/logrotate_fs_ftb branch 2 times, most recently from cb4410e to e3f1bda Compare November 5, 2024 23:16
@blt
Copy link
Contributor Author

blt commented Nov 6, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 6, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@blt
Copy link
Contributor Author

blt commented Nov 6, 2024

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Nov 6, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

blt added 2 commits November 6, 2024 14:05
This commit updates the file_to_blackhole experiments to rely on the lading
logrotate FS generator, allowing us to assert on whether the log Agent loses
bytes in the course of its operation. I've added a new check asserting that no
bytes are lost, although I do not expect this to pass on higher latency intake
experiments yet.

REF #30744
REF DataDog/lading#1090

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/logrotate_fs_ftb branch from e3f1bda to c8e532c Compare November 6, 2024 22:06
@github-actions github-actions bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels Nov 6, 2024
@blt
Copy link
Contributor Author

blt commented Nov 6, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 6, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Nov 6, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit cf1046f into main Nov 6, 2024
199 of 201 checks passed
@dd-mergequeue dd-mergequeue bot deleted the blt/logrotate_fs_ftb branch November 6, 2024 23:46
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/single-machine-performance Single Machine Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants