[ASCII-2428] Create a metaCollector singleton #30772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we no longer need to provide an optional workloadmeta when calling the tagger functions This would allow us to fully decouple the different tagger implementation into separate packages, and ensuring the remote tagger implementation do not have a reference to the workloadmeta component
GustavoCaso
changed the title
github-actions
bot
added
team/container-platform
GustavoCaso
added
changelog/no-changelog
and removed
medium review
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48328531 --os-family=ubuntuNote: This applies to commit 3465c8f |
GustavoCaso
added
qa/done
GustavoCaso
removed
the
qa/done
vickenty
reviewed
Nov 6, 2024
| ) | ||
|
|
||
| func TestStartCommand(t *testing.T) { | ||
| fxutil.TestOneShotSubcommand(t, | ||
| []*cobra.Command{MakeCommand("defaultLogFile")}, | ||
| []string{"start", "--cfgpath", "PATH"}, | ||
| []string{"start"}, |
There was a problem hiding this comment.
Is this change really necessary for workloadmeta decoupling?
| @@ -81,7 +79,7 @@ func newParser(cfg model.Reader, float64List *float64ListPool, workerNum int, wm | |||
| readTimestamps: readTimestamps, | |||
| float64List: float64List, | |||
| dsdOriginEnabled: cfg.GetBool("dogstatsd_origin_detection_client"), | |||
| provider: provider.GetProvider(wmeta), | |||
| provider: provider.GetMetaCollector(), | |||
There was a problem hiding this comment.
This seems unnecessarily fragile. Before this change the provider was made sure to be initialized whenever it was used, now this depends on the code scattered around cmd for this. (GetProvider starts a background process that feeds data into the meta collector, but GetMetaCollector does not). I get the need to decouple the tagger component from the workloadmeta, but is there really any need to decouple the dogstatsd server?
ichinaski
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create a metaCollector singleton
Motivation
That way we no longer need to provide an optional workloadmeta when calling the tagger functions
This would allow us to fully decouple the different tagger implementation into separate packages, and ensuring the remote tagger implementation do not have a reference to the workloadmeta component
The last three commits also refactor a few places in the codebase that there were passing an optional workloadmeta. component to get the
MetaCollectorpkg/flareThe future
Ideally the
util/containers/metricsshould become its own component. That would avoid the usage of globals. Creating the component is a much bigger change. This change unblocks us from splitting the tagger component into multiple implementations, but ideally, we should create a separate component and pass it as a dependency to the places that used it.Describe how to test/QA your changes
Unit tests are updated
[TBD] How to to test origin detection mode
Possible Drawbacks / Trade-offs
Additional Notes