Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 7.59.x] Bump test-infra-definitions to 0a48ed72 #30806

Conversation

pducolin
Copy link
Contributor

@pducolin pducolin commented Nov 6, 2024

Backport 32a1580 from #30709.


This PR was automatically created by the test-infra-definitions bump task.

This PR bumps the test-infra-definitions submodule to 0a48ed7298221d8ab5cdef39f5d50679a523411b from f3aa4172342a.
Here is the full changelog between the two commits: DataDog/test-infra-definitions@f3aa417...0a48ed7

⚠️ This PR is opened with the qa/no-code-change and changelog/no-changelog labels by default. Please make sure this is appropriate

@pducolin pducolin added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation backport labels Nov 6, 2024
@pducolin pducolin requested review from a team as code owners November 6, 2024 13:38
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 6, 2024

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
1 159 1 0

ℹ️ Diff available in the job log.

@pducolin pducolin requested a review from a team as a code owner November 6, 2024 14:13
@pducolin pducolin force-pushed the pducolin/backport-test-infra-0a48ed7298221d8ab5cdef39f5d50679a523411b branch from ecb940e to 155060f Compare November 6, 2024 14:46
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 6, 2024

[Fast Unit Tests Report]

On pipeline 48430977 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Nov 6, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b3633c58-f411-40f3-82d3-3fa7940c2dc5

Baseline: 25b842b
Comparison: ddee35b
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization -12.80 [-16.54, -9.06] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +2.91 [+2.77, +3.05] 1 Logs
idle_all_features memory utilization +0.77 [+0.63, +0.90] 1 Logs
otel_to_otel_logs ingress throughput +0.42 [-0.39, +1.23] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.48 [-1.20, +0.25] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.74 [-0.80, -0.68] 1 Logs
idle memory utilization -0.99 [-1.05, -0.93] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.78 [-5.34, +1.79] 1 Logs
basic_py_check % cpu utilization -12.80 [-16.54, -9.06] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
idle memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pducolin pducolin requested review from a team as code owners November 7, 2024 09:52
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48430977 --os-family=ubuntu

Note: This applies to commit ddee35b

@pducolin
Copy link
Contributor Author

pducolin commented Nov 7, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 7, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-07 13:45:45 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in 7.59.x is 40m.

@dd-mergequeue dd-mergequeue bot merged commit afbb175 into 7.59.x Nov 7, 2024
369 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pducolin/backport-test-infra-0a48ed7298221d8ab5cdef39f5d50679a523411b branch November 7, 2024 14:08
@github-actions github-actions bot added this to the 7.59.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant