Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wmeta: add nvml collector #32109
wmeta: add nvml collector #32109
Changes from 3 commits
194f77e
8f6cf87
faec403
ba72359
fd6679c
1946f2c
234f4e6
bc5f282
8a226b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the permission for core agent an issue? I thought one of your RFC mentioned insufficient permission to access the GPU via nvml lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only an issue in our staging environments, in any case the permission failure would show up before when trying to start the collector. We haven't seen failures once the NVML library is initialised, as it seems to keep the handles to the devices open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: are there any cases where an Nvidia GPU can be "removed" from the environment or nvml can't detect it anymore requiring an `workloadmeta.EventTypeUnset? In the GPU case it seems impossible to happen but this is the only difference between the other collectors. Otherwise your collector looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A GPU could get disconnected (e.g., disabling the PCI device), although that's not normal operation. I can add support for that just in case though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's really needed, I was following the structure of the other collectors that do have this file (and the
_nop.go
file too)