Update ProgramData Directory permissions #32117

jack0x2 · 2024-12-12T23:39:26Z

What does this PR do?

Updates permissions of ProgramData folder for windows operating systems.

Motivation

https://datadoghq.atlassian.net/browse/WINA-1232

Describe how you validated your changes

Tested by existing e2e tests.

Possible Drawbacks / Trade-offs

Removes inherited write permissions to data directory meaning any custom log, run, etc. paths the agent needs to be given explicit write access if not created by the agent.

Additional Notes

agent-platform-auto-pr · 2024-12-13T00:18:02Z

[Fast Unit Tests Report]

On pipeline 52281716 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

agent-platform-auto-pr · 2024-12-13T00:46:18Z

Package size comparison

Comparison with ancestor a2310cfe86c7bda2031672e1268cb749d631ec40

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1265.94MB	1265.94MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.28MB	113.28MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.52MB	78.52MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	502.50MB	502.50MB	70.00MB
datadog-agent-x86_64-rpm	0.00MB	⚠️	1275.18MB	1275.18MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	⚠️	1275.18MB	1275.18MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.35MB	113.35MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.35MB	113.35MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.59MB	78.59MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.59MB	78.59MB	10.00MB
datadog-agent-arm64-deb	-0.00MB	✅	1001.02MB	1001.02MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.76MB	108.76MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.74MB	55.74MB	10.00MB
datadog-agent-aarch64-rpm	-0.00MB	✅	1010.23MB	1010.24MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.83MB	108.83MB	10.00MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2024-12-13T00:48:49Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52281716 --os-family=ubuntu

Note: This applies to commit 8cd00f3

cit-pr-commenter · 2024-12-13T01:13:10Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 85ddfdbc-9525-4fc1-b18a-da3c1124b090

Baseline: 274cdd8
Comparison: 8cd00f3
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.75	[-0.54, +6.05]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+1.58	[+1.52, +1.65]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.47	[+0.77, +2.17]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.64	[+0.56, +0.72]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.20	[-0.27, +0.67]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.04	[-0.73, +0.82]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.04	[-0.85, +0.93]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.03	[-0.61, +0.68]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.82, +0.86]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.82, +0.84]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.76, +0.77]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.13, +0.10]	1	Logs
➖	quality_gate_idle	memory utilization	-0.06	[-0.10, -0.03]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.40	[-0.53, -0.27]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.47	[-1.27, +0.33]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2024-12-16T21:07:47Z

Uncompressed package size comparison

Comparison with ancestor 274cdd873c71ba931b0bcd6f8dbada88048d7914

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-aarch64-rpm	0.04MB	⚠️	949.89MB	949.85MB	140.00MB
datadog-agent-arm64-deb	0.04MB	⚠️	940.59MB	940.56MB	140.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	506.12MB	506.12MB	70.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.85MB	113.85MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.85MB	113.85MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	109.30MB	109.30MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	79.08MB	79.08MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	79.08MB	79.08MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	79.00MB	79.00MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.11MB	56.11MB	10.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.78MB	113.78MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	109.23MB	109.23MB	10.00MB
datadog-agent-x86_64-rpm	-0.00MB	✅	1207.52MB	1207.53MB	140.00MB
datadog-agent-x86_64-suse	-0.00MB	✅	1207.52MB	1207.53MB	140.00MB
datadog-agent-amd64-deb	-0.00MB	✅	1198.21MB	1198.21MB	140.00MB

Decision

⚠️ Warning

tools/windows/DatadogAgentInstaller/CustomActions/ConfigureUserCustomActions.cs

test/new-e2e/tests/windows/install-test/installtester.go

rtrieu

A few minor suggestions but otherwise looks good.

releasenotes/notes/update-programdata-permissions-6271744e48907d71.yaml

jack0x2 · 2025-01-07T16:04:07Z

/merge

dd-devflow · 2025-01-07T16:04:31Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2025-01-07 16:04:31 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 36m.

2025-01-07 17:08:55 UTC ℹ️ MergeQueue: This merge request was merged

github-actions bot added team/windows-agent short review PR is simple enough to be reviewed quickly labels Dec 12, 2024

jack0x2 added 9 commits December 16, 2024 13:19

Update ProgramFile Directory permissions

6c06941

fix test permissions

0a02579

remove recursion of file paths

f67d1fe

update formating

98dafd5

fix test permissions

1306c79

update localsystem install test

e21c797

fix windows permissions in install test

544d53c

Remove DD User access on uninstall

49d9900

release notes

efd698a

jack0x2 force-pushed the jack.phillips/update-programdata-permissions branch from e2221aa to efd698a Compare December 16, 2024 20:41

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 16, 2024

jack0x2 added 2 commits December 16, 2024 16:21

lint

45f0b0d

fix argument

148667f

jack0x2 added the qa/done QA done before merge and regressions are covered by tests label Dec 17, 2024

jack0x2 added 3 commits December 18, 2024 10:32

Update Creator Owner permissions

81cb806

Merge branch 'main' into jack.phillips/update-programdata-permissions

2fc6d13

add python-cache to agent access list

eb6b7ae

jack0x2 mentioned this pull request Dec 20, 2024

Add Secrets test in ProgramData #32438

Merged

jack0x2 marked this pull request as ready for review December 30, 2024 18:09

jack0x2 requested review from a team as code owners December 30, 2024 18:09

jack0x2 changed the title ~~Update ProgramFile Directory permissions~~ Update ProgramData Directory permissions Dec 30, 2024

jack0x2 requested a review from clarkb7 December 30, 2024 18:20

aliciascott approved these changes Dec 30, 2024

View reviewed changes

julien-lebot reviewed Jan 3, 2025

View reviewed changes

tools/windows/DatadogAgentInstaller/CustomActions/ConfigureUserCustomActions.cs Outdated Show resolved Hide resolved

clarkb7 reviewed Jan 3, 2025

View reviewed changes

jack0x2 added 8 commits January 5, 2025 16:48

update for feedback

fdefde2

update release notes

880a3d4

Merge branch 'main' into jack.phillips/update-programdata-permissions

1d71ba2

remove select

7367ded

lint

ec55333

update wrong permissions flag

80ab32c

set base to admin/system

29ac57e

update release notes

bbd099e

rtrieu approved these changes Jan 6, 2025

View reviewed changes

github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 6, 2025

release notes

8cd00f3

julien-lebot approved these changes Jan 7, 2025

View reviewed changes

clarkb7 approved these changes Jan 7, 2025

View reviewed changes

dd-mergequeue bot merged commit f250346 into main Jan 7, 2025
235 checks passed

dd-mergequeue bot deleted the jack.phillips/update-programdata-permissions branch January 7, 2025 17:08

github-actions bot added this to the 7.63.0 milestone Jan 7, 2025

mwdd146980 pushed a commit that referenced this pull request Jan 10, 2025

Update ProgramData Directory permissions (#32117)

97a71f5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ProgramData Directory permissions #32117

Update ProgramData Directory permissions #32117

jack0x2 commented Dec 12, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 13, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 13, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 13, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 13, 2024 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

agent-platform-auto-pr bot commented Dec 16, 2024 •

edited

Loading

rtrieu left a comment

jack0x2 commented Jan 7, 2025

dd-devflow bot commented Jan 7, 2025 •

edited

Loading

Update ProgramData Directory permissions #32117

Update ProgramData Directory permissions #32117

Conversation

jack0x2 commented Dec 12, 2024 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Dec 13, 2024 • edited Loading

agent-platform-auto-pr bot commented Dec 13, 2024 • edited Loading

Package size comparison

Decision

agent-platform-auto-pr bot commented Dec 13, 2024 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Dec 13, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Dec 16, 2024 • edited Loading

Uncompressed package size comparison

Decision

rtrieu left a comment

Choose a reason for hiding this comment

jack0x2 commented Jan 7, 2025

dd-devflow bot commented Jan 7, 2025 • edited Loading

Devflow running: /merge

jack0x2 commented Dec 12, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 13, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 13, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 13, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 13, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 16, 2024 •

edited

Loading

dd-devflow bot commented Jan 7, 2025 •

edited

Loading

Devflow running: `/merge`