Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/containerd/cgroups/v3 from 3.0.4 to 3.0.5 #32481

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 23, 2024

Bumps github.com/containerd/cgroups/v3 from 3.0.4 to 3.0.5.

Release notes

Sourced from github.com/containerd/cgroups/v3's releases.

v3.0.5

What's Changed

New Contributors

Full Changelog: containerd/cgroups@v3.0.4...v3.0.5

Commits
  • bce3c7e Merge pull request #358 from thaJeztah/handle_domain_threaded
  • 2236eb0 cgroup2: Manager.Delete: handle both "threaded" and "domain threaded"
  • d4e976d Merge pull request #355 from akhilerm/return-error-from-inotify
  • 05bb490 add InotifyInit err to custom err message
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Dec 23, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 23, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 23, 2024

Uncompressed package size comparison

Comparison with ancestor 7b0a606fcc66c9484ccfffc18fe2df0f1b3aba96

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 928.85MB 928.85MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 938.59MB 938.59MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 938.59MB 938.59MB 0.50MB
datadog-agent-arm64-deb 0.00MB 916.06MB 916.06MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 925.78MB 925.78MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.99MB 58.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.07MB 59.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.07MB 59.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.48MB 56.48MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.87MB 477.87MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.88MB 93.88MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm -0.00MB 90.00MB 90.00MB 0.50MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Dec 23, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c971dce5-3b37-4409-8738-9b8a662b872d

Baseline: 7b0a606
Comparison: de757fc
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.32 [+0.41, +2.23] 1 Logs
quality_gate_idle_all_features memory utilization +0.75 [+0.70, +0.79] 1 Logs bounds checks dashboard
file_tree memory utilization +0.37 [+0.32, +0.42] 1 Logs
quality_gate_logs % cpu utilization +0.33 [-2.75, +3.40] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.26, +0.31] 1 Logs
quality_gate_idle memory utilization +0.02 [-0.02, +0.05] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.63, +0.66] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.05, +0.02] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.05 [-0.94, +0.85] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.75, +0.63] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.07 [-0.96, +0.82] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.09 [-0.92, +0.75] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.16 [-0.95, +0.62] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.21 [-0.68, +0.25] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.71 [-1.49, +0.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.81 [-0.90, -0.72] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

@L3n41c L3n41c added team/containers qa/done QA done before merge and regressions are covered by tests and removed team/triage labels Jan 24, 2025
@L3n41c
Copy link
Member

L3n41c commented Jan 24, 2025

/merge

@L3n41c
Copy link
Member

L3n41c commented Jan 24, 2025

@dependabot rebase

@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-24 09:34:58 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-24 13:35:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 24, 2025

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@L3n41c
Copy link
Member

L3n41c commented Jan 24, 2025

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/containerd/cgroups/v3-3.0.5 branch from 3f91b6c to 3a5a279 Compare January 24, 2025 09:37
@L3n41c
Copy link
Member

L3n41c commented Jan 24, 2025

@dependabot rebase

Bumps [github.com/containerd/cgroups/v3](https://github.com/containerd/cgroups) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/containerd/cgroups/releases)
- [Commits](containerd/cgroups@v3.0.4...v3.0.5)

---
updated-dependencies:
- dependency-name: github.com/containerd/cgroups/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/containerd/cgroups/v3-3.0.5 branch from 3a5a279 to 87facf2 Compare January 24, 2025 10:38
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed short review PR is simple enough to be reviewed quickly labels Jan 24, 2025
@L3n41c
Copy link
Member

L3n41c commented Jan 24, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-24 15:24:31 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-24 17:38:14 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 34m.


2025-01-24 18:11:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 9547dfc into main Jan 24, 2025
249 of 253 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dependabot/go_modules/github.com/containerd/cgroups/v3-3.0.5 branch January 24, 2025 18:11
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant