Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fleet): Add install info on installer script install #32646

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

BaptisteFoy
Copy link
Contributor

@BaptisteFoy BaptisteFoy commented Jan 3, 2025

What does this PR do?

Adds install method for the "installer install script"

Motivation

Clean install method for the new "installer install script"; that include flavors

Describe how you validated your changes

Manual QA on a VM

Possible Drawbacks / Trade-offs

Only the Datadog installer uses these methods so there will be no impact on the other install methods whatsoever.

Additional Notes

@BaptisteFoy BaptisteFoy added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Jan 3, 2025
@github-actions github-actions bot added the medium review PR review might take time label Jan 3, 2025
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/install-script-install-info branch from 90f2180 to 919645a Compare January 3, 2025 14:34
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 3, 2025

Uncompressed package size comparison

Comparison with ancestor 97e21b68ef14225946b43f673e3a9ef5ad42e7fa

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.02MB ⚠️ 949.82MB 949.80MB 140.00MB
datadog-agent-arm64-deb 0.02MB ⚠️ 940.53MB 940.50MB 140.00MB
datadog-agent-x86_64-rpm 0.02MB ⚠️ 1207.45MB 1207.43MB 140.00MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 1207.45MB 1207.43MB 140.00MB
datadog-agent-amd64-deb 0.02MB ⚠️ 1198.13MB 1198.11MB 140.00MB
datadog-heroku-agent-amd64-deb 0.00MB 506.10MB 506.10MB 70.00MB
datadog-dogstatsd-amd64-deb 0.00MB 79.00MB 79.00MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 56.11MB 56.11MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.77MB 113.77MB 10.00MB
datadog-iot-agent-aarch64-rpm -0.00MB 109.29MB 109.29MB 10.00MB
datadog-iot-agent-x86_64-rpm -0.00MB 113.84MB 113.84MB 10.00MB
datadog-iot-agent-x86_64-suse -0.00MB 113.84MB 113.84MB 10.00MB
datadog-dogstatsd-x86_64-rpm -0.00MB 79.08MB 79.08MB 10.00MB
datadog-dogstatsd-x86_64-suse -0.00MB 79.08MB 79.08MB 10.00MB
datadog-iot-agent-arm64-deb -0.00MB 109.22MB 109.22MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 3, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52206701 --os-family=ubuntu

Note: This applies to commit f6ac69f

@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/install-script-install-info branch from 919645a to a639022 Compare January 3, 2025 15:26
Copy link

cit-pr-commenter bot commented Jan 3, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3a413f91-ddad-4530-8e48-43fdc7880252

Baseline: 97e21b6
Comparison: f6ac69f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.68 [+0.59, +0.77] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.52 [-0.26, +1.29] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.78, +0.89] 1 Logs
quality_gate_idle_all_features memory utilization +0.05 [-0.03, +0.13] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.65] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.87, +0.85] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.85, +0.83] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.73, +0.70] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.03 [-0.49, +0.44] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.88, +0.69] 1 Logs
quality_gate_idle memory utilization -0.19 [-0.23, -0.15] 1 Logs bounds checks dashboard
file_tree memory utilization -0.31 [-0.44, -0.18] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.50 [-1.19, +0.18] 1 Logs
quality_gate_logs % cpu utilization -1.53 [-4.72, +1.67] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/install-script-install-info branch 5 times, most recently from ac4fb1c to f99c345 Compare January 6, 2025 09:07
@BaptisteFoy BaptisteFoy marked this pull request as ready for review January 6, 2025 09:26
@BaptisteFoy BaptisteFoy requested review from a team as code owners January 6, 2025 09:26
@BaptisteFoy BaptisteFoy requested a review from misteriaud January 6, 2025 09:26
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/install-script-install-info branch from f99c345 to f6ac69f Compare January 6, 2025 09:31
Copy link
Contributor

@jeremy-hanna jeremy-hanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for ASC

@BaptisteFoy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-07 08:46:43 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-07 09:24:00 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8d4d386 into main Jan 7, 2025
238 checks passed
@dd-mergequeue dd-mergequeue bot deleted the baptiste.foy/FA/install-script-install-info branch January 7, 2025 09:23
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants