Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] onboard second batch of fs constants to the fetcher #32732

Merged
merged 10 commits into from
Jan 7, 2025

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

second part of #32700

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@paulcacheux paulcacheux added changelog/no-changelog team/agent-security qa/done QA done before merge and regressions are covered by tests labels Jan 7, 2025
@paulcacheux paulcacheux requested a review from a team as a code owner January 7, 2025 15:05
@github-actions github-actions bot added component/system-probe medium review PR review might take time labels Jan 7, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 7, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52380663 --os-family=ubuntu

Note: This applies to commit 6f1383a

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 7, 2025

Uncompressed package size comparison

Comparison with ancestor 44411ed7c91af334aab2d44b3b0a7dda4db0d9d6

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.11MB ⚠️ 950.18MB 950.07MB 140.00MB
datadog-agent-arm64-deb 0.11MB ⚠️ 940.89MB 940.78MB 140.00MB
datadog-agent-amd64-deb 0.10MB ⚠️ 1011.52MB 1011.42MB 140.00MB
datadog-agent-x86_64-rpm 0.10MB ⚠️ 1020.84MB 1020.73MB 140.00MB
datadog-agent-x86_64-suse 0.10MB ⚠️ 1020.84MB 1020.73MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 58.62MB 58.62MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.70MB 58.70MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.70MB 58.70MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 56.13MB 56.13MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 506.16MB 506.16MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.81MB 113.81MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.88MB 113.88MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.88MB 113.88MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 109.25MB 109.25MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.32MB 109.32MB 10.00MB

Decision

⚠️ Warning

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 7, 2025
Copy link

cit-pr-commenter bot commented Jan 7, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c11c9c56-3d27-41e0-bce8-6779c5ff064d

Baseline: 44411ed
Comparison: 6f1383a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.21 [+0.15, +0.27] 1 Logs
quality_gate_idle memory utilization +0.17 [+0.13, +0.21] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.14 [-0.63, +0.92] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.06 [-0.40, +0.53] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.83, +0.93] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.70, +0.72] 1 Logs
quality_gate_idle_all_features memory utilization +0.01 [-0.09, +0.10] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.90, +0.91] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.12] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.65, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.96, +0.94] 1 Logs
file_tree memory utilization -0.16 [-0.30, -0.03] 1 Logs
quality_gate_logs % cpu utilization -0.35 [-3.57, +2.86] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.47 [-1.25, +0.31] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.51 [-2.17, -0.85] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux paulcacheux force-pushed the paulcacheux/missing-fs-constants-v2 branch from 79f88c8 to b3744f2 Compare January 7, 2025 17:08
@github-actions github-actions bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels Jan 7, 2025
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 7, 2025
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-07 21:27:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-07 21:51:48 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 37m.


2025-01-07 22:24:02 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit dd4b4c2 into main Jan 7, 2025
230 of 231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/missing-fs-constants-v2 branch January 7, 2025 22:24
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 7, 2025
mwdd146980 pushed a commit that referenced this pull request Jan 10, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants