Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind auto_multi_line_detection_custom_samples to env var #32788

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gh123man
Copy link
Member

@gh123man gh123man commented Jan 8, 2025

What does this PR do?

Fix logs_config.auto_multi_line_detection_custom_samples so it also works with an env var.

Motivation

Users should be able to configure auto_multi_line_detection_custom_samples with an env var.

Describe how you validated your changes

  1. Run the agent with DD_LOGS_CONFIG_AUTO_MULTI_LINE_DETECTION_CUSTOM_SAMPLES configured ex:
DD_LOGS_CONFIG_AUTO_MULTI_LINE_DETECTION_CUSTOM_SAMPLES: '[{ "sample": "a log sample" }]'
  1. emit some logs that match the log sample
  2. run agent status -v and confirm that the matching user_pattern matched (or check the logs explorer that logs were combined)

Possible Drawbacks / Trade-offs

Additional Notes

@gh123man gh123man added changelog/no-changelog team/agent-metrics-logs qa/done QA done before merge and regressions are covered by tests labels Jan 8, 2025
@gh123man gh123man added this to the 7.62.0 milestone Jan 8, 2025
@gh123man gh123man changed the title Bind auto_multi_line_detection_custom_samples custom samples to env var Bind auto_multi_line_detection_custom_samples to env var Jan 8, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 8, 2025
@gh123man gh123man marked this pull request as ready for review January 8, 2025 18:32
@gh123man gh123man requested a review from a team as a code owner January 8, 2025 18:32
@gh123man gh123man requested a review from jeremy-hanna January 8, 2025 18:32
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 8, 2025

Uncompressed package size comparison

Comparison with ancestor b97c90616b68239053e33f46f4db6900f2c59f4a

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-arm64-deb 2.29MB 56.14MB 53.85MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.92MB 113.89MB 112.97MB 0.50MB
datadog-iot-agent-x86_64-suse 0.92MB 113.89MB 112.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.92MB 113.82MB 112.90MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.72MB 109.33MB 108.61MB 0.50MB
datadog-iot-agent-arm64-deb 0.72MB 109.26MB 108.54MB 0.50MB
datadog-heroku-agent-amd64-deb -0.38MB 506.18MB 506.56MB 0.50MB
datadog-dogstatsd-x86_64-rpm -17.52MB 58.71MB 76.22MB 0.50MB
datadog-dogstatsd-x86_64-suse -17.52MB 58.71MB 76.22MB 0.50MB
datadog-dogstatsd-amd64-deb -17.52MB 58.63MB 76.15MB 0.50MB
datadog-agent-aarch64-rpm -56.57MB 950.25MB 1006.83MB 0.50MB
datadog-agent-arm64-deb -56.70MB 940.96MB 997.66MB 0.50MB
datadog-agent-x86_64-rpm -261.68MB 1020.91MB 1282.59MB 0.50MB
datadog-agent-x86_64-suse -261.68MB 1020.91MB 1282.59MB 0.50MB
datadog-agent-amd64-deb -261.81MB 1011.59MB 1273.40MB 0.50MB

Decision

❌ Failed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 8, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52481658 --os-family=ubuntu

Note: This applies to commit 616b1e8

Copy link

cit-pr-commenter bot commented Jan 8, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3054a734-80cf-4657-bb9c-ac36c3463796

Baseline: 832149a
Comparison: 616b1e8
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.90 [-1.36, +5.15] 1 Logs
file_tree memory utilization +0.41 [+0.27, +0.54] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.37 [-0.30, +1.05] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.30 [-0.17, +0.76] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.27 [-0.51, +1.05] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.10 [-0.70, +0.90] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.85, +0.88] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.70, +0.70] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.05 [-0.91, +0.81] 1 Logs
quality_gate_idle memory utilization -0.10 [-0.14, -0.06] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.13 [-0.22, -0.03] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.33 [-1.10, +0.44] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.72 [-0.79, -0.66] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-metrics-logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants