Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4550] Fix pkg/clusteragent/autoscaling/workload/loadstore/TestStoreAndPurgeEntities #32794

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

zhuminyi
Copy link
Contributor

@zhuminyi zhuminyi commented Jan 8, 2025

What does this PR do?

Fix TestStoreAndPurgeEntities by checking the PodOwner field explicitly.

Motivation

The unit test dump the results by array. The elements in the array is ordered by their hash value: HashFunc<namespace, deployment, metricName>.

func generateHash(strings ...string) uint64 {
	// Initialize a new FNV-1a hasher
	hasher := fnv.New64a()
	// Iterate over the strings and write each one to the hasher
	for _, str := range strings {
		hasher.Write([]byte(str))
	}
	return hasher.Sum64()
}

The FNV algorithm itself is independent of machine architecture. The input <namespace, deployment, metricName> to the hash function is derived from binary data, the endianness (byte order) of the machine might affect the input. Therefore the order of the result array is not independent of machine architecture.

Describe how you validated your changes

QA done by unit test

Possible Drawbacks / Trade-offs

Additional Notes

@zhuminyi zhuminyi added qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team labels Jan 8, 2025
@zhuminyi zhuminyi added this to the 7.62.0 milestone Jan 8, 2025
@zhuminyi zhuminyi requested a review from a team as a code owner January 8, 2025 21:16
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 8, 2025
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 52489171 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor b97c90616b68239053e33f46f4db6900f2c59f4a

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-arm64-deb 2.29MB 56.14MB 53.85MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.92MB 113.89MB 112.97MB 0.50MB
datadog-iot-agent-x86_64-suse 0.92MB 113.89MB 112.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.92MB 113.82MB 112.90MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.72MB 109.33MB 108.61MB 0.50MB
datadog-iot-agent-arm64-deb 0.72MB 109.26MB 108.54MB 0.50MB
datadog-heroku-agent-amd64-deb -0.38MB 506.18MB 506.56MB 0.50MB
datadog-dogstatsd-x86_64-rpm -17.52MB 58.71MB 76.22MB 0.50MB
datadog-dogstatsd-x86_64-suse -17.52MB 58.71MB 76.22MB 0.50MB
datadog-dogstatsd-amd64-deb -17.52MB 58.63MB 76.15MB 0.50MB
datadog-agent-aarch64-rpm -56.57MB 950.25MB 1006.83MB 0.50MB
datadog-agent-arm64-deb -56.70MB 940.96MB 997.66MB 0.50MB
datadog-agent-x86_64-rpm -261.68MB 1020.91MB 1282.59MB 0.50MB
datadog-agent-x86_64-suse -261.68MB 1020.91MB 1282.59MB 0.50MB
datadog-agent-amd64-deb -261.81MB 1011.59MB 1273.40MB 0.50MB

Decision

❌ Failed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52489171 --os-family=ubuntu

Note: This applies to commit 48ea719

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2713b566-d866-4b69-b31e-77a0b9d20da7

Baseline: 832149a
Comparison: 48ea719
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_500ms_latency egress throughput +0.20 [-0.57, +0.98] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.15 [-0.51, +0.82] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.06 [-0.68, +0.81] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.05 [-0.85, +0.94] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.10, +0.14] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.45, +0.47] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.64, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.02, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.95, +0.90] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.91, +0.78] 1 Logs
quality_gate_idle_all_features memory utilization -0.16 [-0.25, -0.08] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.21 [-3.41, +2.99] 1 Logs
file_tree memory utilization -0.38 [-0.51, -0.24] 1 Logs
quality_gate_idle memory utilization -0.41 [-0.44, -0.37] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.44 [-1.27, +0.38] 1 Logs
tcp_syslog_to_blackhole ingress throughput -2.48 [-2.58, -2.39] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@zhuminyi
Copy link
Contributor Author

zhuminyi commented Jan 8, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 8, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-08 23:43:44 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 36m.


2025-01-09 00:18:49 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c8aab9b into main Jan 9, 2025
251 of 256 checks passed
@dd-mergequeue dd-mergequeue bot deleted the fix_TestStoreAndPurgeEntities branch January 9, 2025 00:18
@github-actions github-actions bot modified the milestones: 7.62.0, 7.63.0 Jan 9, 2025
github-actions bot pushed a commit to mamebb2023/datadog-agent that referenced this pull request Jan 9, 2025
mwdd146980 pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants