Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWS: sync BTFHub constants #32835

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

github-actions[bot]
Copy link
Contributor

What does this PR do?

This PR syncs the BTFHub constants used by CWS
This PR was autogenerated

@github-actions github-actions bot added this to the Triage milestone Jan 10, 2025
@github-actions github-actions bot added qa/no-code-change No code change in Agent code requiring validation team/agent-security labels Jan 10, 2025
@github-actions github-actions bot requested a review from a team as a code owner January 10, 2025 05:16
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor fa88b009ec397efe8856b1921e3289e85652ca99

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 941.95MB 941.95MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.83MB 58.83MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.33MB 56.33MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 506.57MB 506.57MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 114.00MB 114.00MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 114.07MB 114.07MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 114.07MB 114.07MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 109.44MB 109.44MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.51MB 109.51MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 951.24MB 951.24MB 0.50MB
datadog-agent-amd64-deb -0.01MB 1012.77MB 1012.78MB 0.50MB
datadog-agent-x86_64-rpm -0.01MB 1022.09MB 1022.10MB 0.50MB
datadog-agent-x86_64-suse -0.01MB 1022.09MB 1022.10MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 52630999 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9f7d79f2-79ae-4243-9434-347d147d3fef

Baseline: fa88b00
Comparison: 0324ddd
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.34 [+0.66, +2.01] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.31 [-0.47, +1.09] 1 Logs
quality_gate_idle_all_features memory utilization +0.15 [+0.06, +0.25] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.14 [-0.32, +0.60] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.06 [-0.00, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.60, +0.68] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.82, +0.88] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.84, +0.90] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.64, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.12] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.83, +0.74] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.93, +0.83] 1 Logs
quality_gate_idle memory utilization -0.34 [-0.38, -0.31] 1 Logs bounds checks dashboard
file_tree memory utilization -0.51 [-0.63, -0.39] 1 Logs
quality_gate_logs % cpu utilization -2.23 [-5.45, +0.98] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux paulcacheux added qa/no-code-change No code change in Agent code requiring validation and removed qa/no-code-change No code change in Agent code requiring validation labels Jan 10, 2025
@paulcacheux
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 10, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-10 07:07:19 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-10 07:42:32 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c3f84f7 into main Jan 10, 2025
235 checks passed
@dd-mergequeue dd-mergequeue bot deleted the cws/constants-sync-1736486200 branch January 10, 2025 07:42
@github-actions github-actions bot modified the milestones: Triage, 7.63.0 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant