Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable diagnose port conflict on windows #32878

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mwdd146980
Copy link
Contributor

@mwdd146980 mwdd146980 commented Jan 10, 2025

What does this PR do?

Add windows compatibility for the diagnose port conflict suite. This builds on [PR#25209 (https://github.com//pull/25209).

Created new PR because I messed up my commits from [PR#27457] (#27457).

Motivation

Making this feature available for Windows makes this feature available on all OSes.

Describe how to test/QA your changes

Check that the diagnose suite works properly for Windows:

  • when the agent isn't running and there is no port issue
  • when the agent is running and there is no port issue (the agent is detected as being the agent, so no issue is raised)
  • when some port is used by another process, it is reported
    You can use netcat to bind to a port:
netcat -nvlp 6062

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@mwdd146980 mwdd146980 requested a review from a team as a code owner January 10, 2025 19:15
@mwdd146980 mwdd146980 requested a review from hush-hush January 10, 2025 19:15
@mwdd146980 mwdd146980 self-assigned this Jan 10, 2025
@mwdd146980 mwdd146980 requested review from iglendd and removed request for hush-hush January 10, 2025 19:15
@github-actions github-actions bot added long review PR is complex, plan time to review it team/agent-shared-components labels Jan 10, 2025
@mwdd146980 mwdd146980 added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Jan 10, 2025
@mwdd146980 mwdd146980 added this to the 7.62.0 milestone Jan 10, 2025
Copy link

cit-pr-commenter bot commented Jan 10, 2025

Go Package Import Differences

Baseline: 17111e2
Comparison: 99793f3

binaryosarchchange
security-agentwindowsamd64
+1, -0
+golang.org/x/sys/cpu

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 10, 2025

Uncompressed package size comparison

Comparison with ancestor 17111e224cc9ac7381802e442b604c37bee63eda

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 939.29MB 939.28MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 948.59MB 948.58MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.70MB 109.69MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.83MB 58.83MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.33MB 56.33MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 506.82MB 506.82MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 114.20MB 114.20MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 109.63MB 109.63MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.00MB 114.27MB 114.27MB 0.50MB
datadog-iot-agent-x86_64-suse -0.00MB 114.27MB 114.27MB 0.50MB
datadog-agent-x86_64-rpm -0.03MB 1018.81MB 1018.84MB 0.50MB
datadog-agent-x86_64-suse -0.03MB 1018.81MB 1018.84MB 0.50MB
datadog-agent-amd64-deb -0.03MB 1009.49MB 1009.52MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 10, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52725593 --os-family=ubuntu

Note: This applies to commit 99793f3

Copy link

cit-pr-commenter bot commented Jan 10, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: edc4c6a9-ac99-44d6-bdd9-5f5b210ec155

Baseline: 17111e2
Comparison: a30e729
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.25 [-0.01, +6.50] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.00 [+0.28, +1.72] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.80 [+0.01, +1.59] 1 Logs
quality_gate_idle_all_features memory utilization +0.31 [+0.23, +0.40] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.22 [+0.18, +0.26] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.92, +0.99] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.65] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.72, +0.73] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.10, +0.07] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.96, +0.87] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.07 [-0.89, +0.75] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.19 [-0.65, +0.27] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.34 [-1.12, +0.43] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.35 [-0.43, -0.28] 1 Logs
file_tree memory utilization -0.77 [-0.90, -0.64] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@mwdd146980 mwdd146980 requested a review from a team as a code owner January 10, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant