[POC] Check Python paths to determine if a check is Python #32922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paths to determine if a check might be Python
github-actions
bot
added
the
short review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Get Python's
sys.path, and use it to check if a check has a Python version, rather than loading it.Motivation
It would allow checking if a check is Python without loading Python, which would unblock checks-agent POC or lazy loading rtloader POC.
Describe how you validated your changes
Possible Drawbacks / Trade-offs
As is, this doesn't really help, since there is an
iodefault check, and also aniostandard library module, so we would always have to start Python to know if it's an actual check or not.We could just hardcode that
iois an exception and we know it's Go, but it also means break any user using aniocustom check...Additional Notes
I'm only opening this PR to keep tracks of it.