Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prometheus): [agent6] Deactivate prometheus test which is not supported with python2 #33128

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jan 20, 2025

What does this PR do?

Deactivate the failing TestPrometheus from the containers test suites as it's checking the openmetrics v2 check not enabled in python2

Motivation

Have a greener pipeline

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested review from a team as code owners January 20, 2025 15:00
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 20, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=53490680 --os-family=ubuntu

@chouetz
Copy link
Member Author

chouetz commented Jan 20, 2025

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jan 20, 2025

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2025-01-20 15:47:10 UTC ℹ️ Gitlab pipeline started

Started pipeline #53490680

@chouetz chouetz merged commit 3c183e5 into 6.53.x Jan 21, 2025
301 of 304 checks passed
@chouetz chouetz deleted the nschweitzer/prom branch January 21, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants