Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DJM-587] Collect logs on Dataproc #33152

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

aboitreaud
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added the medium review PR review might take time label Jan 21, 2025
@aboitreaud aboitreaud force-pushed the adrien.boitreaud/log-collection-dataproc branch from 99ab348 to c03aa13 Compare January 21, 2025 09:29
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 21, 2025

Uncompressed package size comparison

Comparison with ancestor 7b0a606fcc66c9484ccfffc18fe2df0f1b3aba96

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 916.06MB 916.06MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 925.78MB 925.78MB 0.50MB
datadog-agent-amd64-deb 0.00MB 928.85MB 928.85MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.99MB 58.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.07MB 59.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.07MB 59.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.48MB 56.48MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.87MB 477.87MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.88MB 93.88MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 938.59MB 938.59MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 938.59MB 938.59MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 21, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54046756 --os-family=ubuntu

Note: This applies to commit fc56476

Copy link

cit-pr-commenter bot commented Jan 21, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6d818eb5-2f53-4e55-8e82-8834cb35ee55

Baseline: 7b0a606
Comparison: fc56476
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.44 [-1.63, +4.51] 1 Logs
quality_gate_idle memory utilization +0.58 [+0.52, +0.64] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.37 [+0.33, +0.41] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.29 [-0.54, +1.11] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.09 [-0.38, +0.56] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.86, +0.99] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.06 [-0.89, +1.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.61, +0.67] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.88, +0.94] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.66, +0.70] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.30, +0.29] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.81, +0.75] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.25 [-1.12, +0.61] 1 Logs
file_tree memory utilization -0.37 [-0.42, -0.32] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.58 [-0.64, -0.51] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@aboitreaud aboitreaud changed the title log collection dataproc [DJM-586] log collection dataproc Jan 22, 2025
@aboitreaud aboitreaud changed the title [DJM-586] log collection dataproc [DJM-587] log collection dataproc Jan 22, 2025
@aboitreaud aboitreaud changed the title [DJM-587] log collection dataproc [DJM-587] Collect logs on Dataproc Jan 22, 2025
@aboitreaud aboitreaud force-pushed the adrien.boitreaud/log-collection-dataproc branch from 4d96b42 to 028732a Compare January 22, 2025 16:59
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Jan 22, 2025
@aboitreaud aboitreaud added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Jan 22, 2025
@aboitreaud aboitreaud force-pushed the adrien.boitreaud/log-collection-dataproc branch from 4d2bf2c to fe96a30 Compare January 23, 2025 15:42
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 23, 2025
@aboitreaud aboitreaud force-pushed the adrien.boitreaud/log-collection-dataproc branch from fe96a30 to e3b20ab Compare January 24, 2025 16:18
So that it's marshalled as "" empty string instead of "[]" that breaks the log config
@aboitreaud aboitreaud force-pushed the adrien.boitreaud/log-collection-dataproc branch from fdc6fad to fc56476 Compare January 27, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant