Add ddprofilingextension #33156
Merged
Add ddprofilingextension #33156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go Package Import DifferencesBaseline: d6ef294
|
github-actions
bot
added
team/opentelemetry
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: d6ef294 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.58 | [-0.29, +1.46] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.55 | [+0.51, +0.60] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.14 | [+0.07, +0.22] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.07 | [+0.00, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.06 | [-0.72, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.02 | [-0.61, +0.66] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.26, +0.29] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.01 | [-0.84, +0.87] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.79, +0.80] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.00 | [-0.86, +0.87] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.01 | [-0.90, +0.88] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.76, +0.74] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.38 | [-0.84, +0.08] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.59 | [-0.67, -0.51] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -1.67 | [-4.69, +1.35] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
Package import difference is explained by this change |
CelianR
approved these changes
Feb 3, 2025
Co-authored-by: Célian Raimbault <[email protected]>
ogaca-dd
approved these changes
Feb 3, 2025
|
|
||
| // profiler.BlockProfile, | ||
| // profiler.MutexProfile, | ||
| // profiler.GoroutineProfile, |
There was a problem hiding this comment.
Added config option to set these.
| if v, ok := c.Agent.Receiver.Handlers[endpoint]; ok { | ||
| return v | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Does the caller is supposed to handle nil?
There was a problem hiding this comment.
Yes, the caller handles the nil
| @@ -15,6 +15,9 @@ exporters: | |||
| extensions: | |||
| ddflare: | |||
| include_metadata: true # Set to true for testing; adjust for production. | |||
| # ddprofiling: | |||
There was a problem hiding this comment.
Is there a reason to have this code commented?
There was a problem hiding this comment.
This will break OCB until: open-telemetry/opentelemetry-collector#12162 is fixed. The PR is up, but not merged yet.
dineshg13
reviewed
Feb 3, 2025
Comment on lines
108
to
112
| // low, but can be enabled as needed. | ||
|
|
||
| // profiler.BlockProfile, | ||
| // profiler.MutexProfile, | ||
| // profiler.GoroutineProfile, |
There was a problem hiding this comment.
can we add these as config options ? We should be able to enable them on demand, with default off
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=54813371 --os-family=ubuntuNote: This applies to commit d540f3e |
misteriaud
approved these changes
Feb 4, 2025
Static quality checks ✅Please find below the results from static quality gates Info
|
dineshg13
approved these changes
Feb 4, 2025
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a ddprofiling extension. This extension starts the DD profiler, and is supported in 2 setups:
What does this PR NOT do?
This PR doesn't:
impl. Follow up task: https://datadoghq.atlassian.net/browse/OTEL-2388How to run the extension locally (OTel Agent)
Step 1: Build And Run the core agent:
Step 2: Build and run the otel agent, with the ddprofiling extension in the collector config.
You can use this config for example:
How to run the extension locally (OSS Collector)
Step 1: Install the OCB Builder: https://opentelemetry.io/docs/collector/custom-collector/.
Step 2: Create the manifest
builder-config.yaml, which includes the ddprofilingextension. Please note the path and replaces for ddprofilingextension/def, ddprofilingextension/impl and comp/trace/agent/def which you will need to update based on your current directory.Step 3: Generate the code
Run
./ocb --config=./builder-config.yaml. This will generate the code necessary to run the collector in folder otelcol-dev3 (specified in dist in step above).Step 4: Run the code
cd otelcol-dev3Create collector config with ddprofiling extension:
Run with:
go run main.go components.go main_others.go --config collector.yamlMotivation
OTEL-2310
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes