Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity between Python network check and Go network check #33190

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rahulkaukuntla
Copy link

@rahulkaukuntla rahulkaukuntla commented Jan 21, 2025

What does this PR do?

Adding features to the go network check:

  • allowing for the configuration of the procfs_path to potentially be a path besides "/proc" (mimicked the logic from here)
  • adding general testing coverage to the netstatTCPExtCounters method.
  • adding more TCP and TCPExt metrics from the list of Python check metrics.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@bits-bot
Copy link
Collaborator

bits-bot commented Jan 21, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added team/platform-integrations short review PR is simple enough to be reviewed quickly labels Jan 21, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 21, 2025

Uncompressed package size comparison

Comparison with ancestor 43d0d592cd00b57095ce53b6c4a38dc7e1e09bac

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.03MB ⚠️ 928.66MB 928.63MB 0.50MB
datadog-agent-x86_64-rpm 0.03MB ⚠️ 938.33MB 938.29MB 0.50MB
datadog-agent-x86_64-suse 0.03MB ⚠️ 938.33MB 938.29MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 915.83MB 915.82MB 0.50MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 925.47MB 925.46MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 90.02MB 90.02MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 89.95MB 89.95MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.90MB 93.90MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.97MB 93.97MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.97MB 93.97MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.85MB 58.85MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.93MB 58.93MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.93MB 58.93MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.36MB 56.36MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 478.18MB 478.18MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 21, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53925070 --os-family=ubuntu

Note: This applies to commit 9910431

@github-actions github-actions bot added medium review PR review might take time team/agent-shared-components and removed short review PR is simple enough to be reviewed quickly labels Jan 22, 2025
@rahulkaukuntla rahulkaukuntla added the qa/done QA done before merge and regressions are covered by tests label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants