Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTK-4731] Add logging for flaking API server test #33365

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

kkhor-datadog
Copy link
Contributor

@kkhor-datadog kkhor-datadog commented Jan 24, 2025

What does this PR do?

Adds logging to a test that is currently flaking in CI.

Motivation

Help with debugging flakes in the test. Currently the only output when the test fails is as follows, so it's not clear where the test is failing:

mock.go:31: 2025-01-23 18:18:23 UTC | INFO | (comp/core/tagger/impl/tagger.go:107 in NewComponent) | TaggerClient is created, defaultTagger type:  *mock.FakeTagger
    mock.go:31: 2025-01-23 18:18:23 UTC | INFO | (comp/process/apiserver/apiserver.go:55 in newApiServer) | API server listening on localhost:59425
    mock.go:31: 2025-01-23 18:18:23 UTC | INFO | (comp/core/workloadmeta/impl/store.go:100 in start) | workloadmeta store initialized successfully
    apiserver_test.go:95: 
        	Error Trace:	C:/buildroot/datadog-agent/comp/process/apiserver/apiserver_test.go:95
        	Error:      	Condition never satisfied
        	Test:       	TestPostAuthentication

Describe how you validated your changes

Validated that the new logging is present in CI job logs:

2025-01-24T16:46:33.990001Z 01O     mock.go:31: 2025-01-24 16:46:14 UTC | INFO | (comp/process/apiserver/apiserver.go:55 in newApiServer) | API server listening on localhost:43609
2025-01-24T16:46:33.990009Z 01O     mock.go:31: 2025-01-24 16:46:14 UTC | INFO | (comp/core/workloadmeta/impl/store.go:100 in start) | workloadmeta store initialized successfully
2025-01-24T16:46:33.990014Z 01O     mock.go:31: 2025-01-24 16:46:15 UTC | INFO | (comp/process/apiserver/apiserver_test.go:101 in func2) | Issuing unauthenticated test request to url: https://localhost:43609/config/log_level?value=debug
2025-01-24T16:46:33.990020Z 01O     mock.go:31: 2025-01-24 16:46:15 UTC | WARN | (comp/process/apiserver/apiserver.go:100 in func1) | invalid auth token for POST request to /config/log_level?value=debug: no session token provided
2025-01-24T16:46:33.990041Z 01O     mock.go:31: 2025-01-24 16:46:15 UTC | INFO | (comp/process/apiserver/apiserver_test.go:105 in func2) | Received unauthenticated test response
2025-01-24T16:46:33.990052Z 01O     mock.go:31: 2025-01-24 16:46:15 UTC | INFO | (comp/process/apiserver/apiserver_test.go:110 in func2) | Issuing authenticated test request to url: https://localhost:43609/config/log_level?value=debug
2025-01-24T16:46:33.990058Z 01O     mock.go:31: 2025-01-24 16:46:15 UTC | INFO | (comp/process/apiserver/apiserver_test.go:114 in func2) | Received authenticated test response

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/container-intake fka Processes short review PR is simple enough to be reviewed quickly labels Jan 24, 2025
@kkhor-datadog kkhor-datadog changed the title Add logging for flaking test [CTK-4731] Add logging for flaking API server test Jan 24, 2025
@kkhor-datadog kkhor-datadog added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jan 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 24, 2025

Uncompressed package size comparison

Comparison with ancestor 3a614620fe84b545756c1d4c4de5a97d1bdef955

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 928.85MB 928.85MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 938.59MB 938.59MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 938.59MB 938.59MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 925.78MB 925.78MB 0.50MB
datadog-agent-arm64-deb 0.00MB 916.06MB 916.06MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.99MB 58.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.07MB 59.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.07MB 59.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.48MB 56.48MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.87MB 477.87MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.88MB 93.88MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 24, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53942323 --os-family=ubuntu

Note: This applies to commit 20092f4

@kkhor-datadog kkhor-datadog force-pushed the kkhor/add-test-logging branch from 15ff43c to 20092f4 Compare January 24, 2025 17:17
@kkhor-datadog kkhor-datadog force-pushed the kkhor/add-test-logging branch from 20092f4 to 7943cbb Compare January 24, 2025 17:18
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1bddeadc-d4bf-4322-aa7c-9f3f78799295

Baseline: 3bd70cb
Comparison: 7943cbb
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +0.23 [-0.55, +1.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.10 [-0.67, +0.87] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.73, +0.84] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.83, +0.86] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.29, +0.28] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.62] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.52, +0.41] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.07 [-0.90, +0.75] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.09 [-0.89, +0.71] 1 Logs
file_tree memory utilization -0.18 [-0.22, -0.13] 1 Logs
quality_gate_idle_all_features memory utilization -0.21 [-0.25, -0.17] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.43 [-0.48, -0.37] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.60 [-0.67, -0.53] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.50 [-2.36, -0.65] 1 Logs
quality_gate_logs % cpu utilization -2.61 [-5.58, +0.36] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@kkhor-datadog kkhor-datadog marked this pull request as ready for review January 24, 2025 18:15
@kkhor-datadog kkhor-datadog requested a review from a team as a code owner January 24, 2025 18:15
@kkhor-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-24 18:47:56 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.


2025-01-24 19:24:19 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cd756b3 into main Jan 24, 2025
225 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kkhor/add-test-logging branch January 24, 2025 19:24
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/container-intake fka Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants