Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ubuntu 22.04 for Serverless Integration Tests #33385

Merged

Conversation

duncanpharvey
Copy link
Contributor

What does this PR do?

Pins the Ubuntu version for Serverless Integration tests to 22.04.

Motivation

Serverless Integration tests failing with the below error.

gcc: internal compiler error: Segmentation fault (program cc1)

Describe how you validated your changes

Confirmed that Serverless Integration tests passed successfully.

Possible Drawbacks / Trade-offs

Additional Notes

Tests started failing on this image version:

Runner Image
  Image: ubuntu-24.04
  Version: 20250120.5.0

Tests were previously passing on this image version:

Runner Image
  Image: ubuntu-24.04
  Version: 20250105.1.0

@duncanpharvey duncanpharvey added changelog/no-changelog team/serverless qa/done QA done before merge and regressions are covered by tests labels Jan 24, 2025
@duncanpharvey duncanpharvey requested review from a team as code owners January 24, 2025 21:28
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor bc6097051d789973d4572d1c1710779a0682b454

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 916.09MB 916.09MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.89MB 477.89MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.88MB 93.88MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 925.81MB 925.81MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 938.66MB 938.66MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 938.66MB 938.66MB 0.50MB
datadog-agent-amd64-deb -0.00MB 928.92MB 928.92MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 53970370 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@duncanpharvey
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-24 21:56:23 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-24 22:12:10 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 33m.


2025-01-24 22:34:30 UTC ℹ️ MergeQueue: This merge request was merged

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2a6b8d63-e755-4281-b605-27f52b1a5f7c

Baseline: bc60970
Comparison: 04a129e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.85 [+0.98, +2.72] 1 Logs
quality_gate_logs % cpu utilization +1.40 [-1.67, +4.48] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.96 [+0.16, +1.75] 1 Logs
quality_gate_idle_all_features memory utilization +0.21 [+0.17, +0.25] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.18 [+0.14, +0.22] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.15 [-0.73, +1.02] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.26, +0.30] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.91, +0.89] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.78, +0.74] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.84, +0.74] 1 Logs
file_tree memory utilization -0.09 [-0.14, -0.03] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.10 [-1.02, +0.82] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.50 [-0.97, -0.04] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.19 [-1.27, -1.12] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit 9659f8d into main Jan 24, 2025
255 of 257 checks passed
@dd-mergequeue dd-mergequeue bot deleted the duncan-harvey/serverless-integration-tests-ubuntu-version branch January 24, 2025 22:34
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/serverless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants