[Dashboard CRD] Use fully-qualified domain name finalizer (#1398)

* Use fully-qualified domain name to avoid apiserver warning on dashboard CRD * fix controller unit test
DataDog · Sep 12, 2024 · d44647e · d44647e
1 parent c9cc04d
commit d44647e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/controller/datadogdashboard/controller_test.go b/internal/controller/datadogdashboard/controller_test.go
@@ -77,7 +77,7 @@ func TestReconcileDatadogDashboard_Reconcile(t *testing.T) {
 				if err := c.Get(context.TODO(), types.NamespacedName{Name: resourcesName, Namespace: resourcesNamespace}, db); err != nil {
 					return err
 				}
-				assert.Contains(t, db.GetFinalizers(), "finalizer.dashboard.datadoghq.com")
+				assert.Contains(t, db.GetFinalizers(), "finalizer.datadoghq.com/dashboard")
 				return nil
 			},
 		},

diff --git a/internal/controller/datadogdashboard/finalizer.go b/internal/controller/datadogdashboard/finalizer.go
@@ -18,7 +18,7 @@ import (
 )
 
 const (
-	datadogDashboardFinalizer = "finalizer.dashboard.datadoghq.com"
+	datadogDashboardFinalizer = "finalizer.datadoghq.com/dashboard"
 )
 
 func (r *Reconciler) handleFinalizer(logger logr.Logger, db *datadoghqv1alpha1.DatadogDashboard) (ctrl.Result, error) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,7 @@ import ( @@
     )
     const (
-    	datadogDashboardFinalizer = "finalizer.dashboard.datadoghq.com"
+    	datadogDashboardFinalizer = "finalizer.datadoghq.com/dashboard"
     )
     func (r *Reconciler) handleFinalizer(logger logr.Logger, db *datadoghqv1alpha1.DatadogDashboard) (ctrl.Result, error) {
@@ Expand Down @@