-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(probe): add startup probes #1234
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
==========================================
- Coverage 54.87% 54.84% -0.04%
==========================================
Files 241 241
Lines 27910 27928 +18
==========================================
+ Hits 15317 15318 +1
- Misses 11722 11739 +17
Partials 871 871
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
14b27f9
to
9bd9078
Compare
16e8136
to
d802c04
Compare
Signed-off-by: Wassim DHIF <[email protected]>
f7bf0bb
to
0e03d0a
Compare
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: This merge request was already merged This pull request was merged directly. |
Signed-off-by: Wassim DHIF <[email protected]>
What does this PR do?
Adds Kubernetes startup probe support for:
Motivation
This is needed to add support for the new Kubernetes Startup probe for the Agent components.
Additional Notes
Note that currently the
/startup
endpoint is returning the default/health
endpoint. Support for the dedicated/startup
endpoint has been added in Agent7.55
. No components currently register a startup health check.Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
We can also make sure that the endpoints are working as intended.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label