Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CECO-1153] APM e2e test #1549

Merged
merged 13 commits into from
Jan 10, 2025
Merged

Conversation

tbavelier
Copy link
Member

@tbavelier tbavelier commented Dec 5, 2024

What does this PR do?

Introduces an APM e2e test in two parts:

  • Ensuring traces are received locally (at the Agent level) for all 3 services, using all 3 methods (TCP on hostPort, Agent service and UDP using socket)
  • Ensuring traces are sent to the API

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added this to the v1.12.0 milestone Dec 5, 2024
@tbavelier tbavelier requested a review from a team as a code owner December 5, 2024 09:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.94%. Comparing base (8ad0c66) to head (c3c50d1).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           fanny/refactor-kind-e2e    #1549   +/-   ##
========================================================
  Coverage                    48.94%   48.94%           
========================================================
  Files                          227      227           
  Lines                        20636    20636           
========================================================
  Hits                         10101    10101           
  Misses                       10010    10010           
  Partials                       525      525           
Flag Coverage Δ
unittests 48.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad0c66...c3c50d1. Read the comment docs.

test/e2e/kind_test.go Outdated Show resolved Hide resolved
test/e2e/kind_test.go Outdated Show resolved Hide resolved
@tbavelier tbavelier requested a review from a team as a code owner January 8, 2025 11:38
@tbavelier tbavelier removed this from the v1.12.0 milestone Jan 8, 2025
@tbavelier tbavelier changed the base branch from main to fanny/refactor-kind-e2e January 8, 2025 11:50
Comment on lines +20 to +21
"github.com/DataDog/datadog-agent/test/new-e2e/pkg/provisioners"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to my IDE setting, is no-op and this kind_test.go will be removed eventually post refactor

Copy link
Contributor

@fanny-jiang fanny-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@fanny-jiang fanny-jiang merged commit 4f6af20 into fanny/refactor-kind-e2e Jan 10, 2025
20 checks passed
@fanny-jiang fanny-jiang deleted the tbavelier/ceco-1153 branch January 10, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants