Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require extendeddaemonset/api instead of whole EDS #1558

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

davidor
Copy link
Member

@davidor davidor commented Dec 11, 2024

What does this PR do?

This PR changes the go.mod so that it requires extendeddaemonset/api instead of the whole EDS project.
The new go.mod in EDS has been created in this PR: DataDog/extendeddaemonset#196

The operator was depending on the whole EDS project but in reality it only needs the EDS CRD defined in /api.

Hopefully this will generate less conflicts when upgrading the kubernetes libraries versions.

Describe your test plan

I don't think there's anything specific to test. The project should work exactly as before.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.28%. Comparing base (a3e7eab) to head (292ca91).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1558   +/-   ##
=======================================
  Coverage   49.27%   49.28%           
=======================================
  Files         216      216           
  Lines       20657    20665    +8     
=======================================
+ Hits        10179    10184    +5     
- Misses       9942     9945    +3     
  Partials      536      536           
Flag Coverage Δ
unittests 49.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e7eab...292ca91. Read the comment docs.

@davidor davidor added the enhancement New feature or request label Dec 11, 2024
@davidor davidor force-pushed the davidor/use-eds-crd-go-mod branch from e667ef8 to 698d60d Compare December 16, 2024 09:15
@davidor davidor added this to the v1.12.0 milestone Dec 16, 2024
@davidor davidor force-pushed the davidor/use-eds-crd-go-mod branch 4 times, most recently from 06b3a44 to 4a5d92d Compare December 16, 2024 18:44
@swang392 swang392 modified the milestones: v1.12.0, v1.13.0 Jan 8, 2025
@davidor davidor force-pushed the davidor/use-eds-crd-go-mod branch from 4a5d92d to 136e949 Compare January 9, 2025 11:17
@davidor davidor marked this pull request as ready for review January 9, 2025 11:17
@davidor davidor requested a review from a team as a code owner January 9, 2025 11:17
@davidor davidor force-pushed the davidor/use-eds-crd-go-mod branch from 4b2f495 to 03a6325 Compare January 10, 2025 09:08
@davidor davidor force-pushed the davidor/use-eds-crd-go-mod branch from 03a6325 to 292ca91 Compare January 10, 2025 09:22
@davidor davidor merged commit fb1cc16 into main Jan 10, 2025
19 checks passed
@davidor davidor deleted the davidor/use-eds-crd-go-mod branch January 10, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants