Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service discovery: Add missing cgroup mount (#1610) #1617

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

tbavelier
Copy link
Member

What does this PR do?

Cherry-pick #1610

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

* service discovery: Add missing cgroup mount

Add a missing cgroup mount to system-probe which is required to get
container information.

* Update test
@tbavelier tbavelier added the bug Something isn't working label Jan 10, 2025
@tbavelier tbavelier added this to the v1.12.0 milestone Jan 10, 2025
@tbavelier tbavelier requested a review from a team as a code owner January 10, 2025 08:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.76%. Comparing base (1590012) to head (5bbfb2f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.12    #1617      +/-   ##
==========================================
+ Coverage   48.75%   48.76%   +0.01%     
==========================================
  Files         235      235              
  Lines       21120    21125       +5     
==========================================
+ Hits        10296    10301       +5     
  Misses      10287    10287              
  Partials      537      537              
Flag Coverage Δ
unittests 48.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r/datadogagent/feature/servicediscovery/feature.go 84.61% <100.00%> (+1.28%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1590012...5bbfb2f. Read the comment docs.

@tbavelier tbavelier merged commit 6f16970 into v1.12 Jan 10, 2025
18 checks passed
@tbavelier tbavelier deleted the tbavelier/cherry-pick-1610 branch January 10, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants