Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for otel annotation #1624

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Jan 14, 2025

What does this PR do?

This PR removes support for enabling otel-agent via annotations in favor of enabling otel agent vie otelCollector feature: #1559.

The annotation use has already been removed in staging: https://github.com/DataDog/k8s-datadog-agent-ops/pull/4602.

Motivation

OTEL-2347

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

This PR removes support for enabling otel-agent via annotations in favor of enabling otel agent vie otelCollector feature: #1559.

The annotation use has already been removed in staging: DataDog/k8s-datadog-agent-ops#4602.
@mackjmr mackjmr requested a review from a team as a code owner January 14, 2025 15:31
@mackjmr mackjmr added this to the v1.13.0 milestone Jan 14, 2025
@fanny-jiang
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 14, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-14 20:24:16 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 15m.


2025-01-14 20:24:26 UTCMergeQueue: This merge request is not mergeable, blocked by github

PR can't be merged according to github policy

@fanny-jiang
Copy link
Contributor

/merge --cancel

@dd-devflow
Copy link

dd-devflow bot commented Jan 14, 2025

Devflow running: /merge --cancel

View all feedbacks in Devflow UI.


2025-01-14 20:33:19 UTCDevflow: /merge --cancel

This merge request was already processed and can't be unqueued anymore.

To get help about command usage, write /merge --help

If you need support, contact us on Slack #devflow with those details!

@fanny-jiang fanny-jiang merged commit 841842e into main Jan 14, 2025
29 of 32 checks passed
@fanny-jiang fanny-jiang deleted the mackjmr/remove-otel-annotation branch January 14, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants